Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BufWriter for emitting MIR #68460

Merged
merged 1 commit into from Feb 2, 2020
Merged

Use BufWriter for emitting MIR #68460

merged 1 commit into from Feb 2, 2020

Conversation

@sinkuu
Copy link
Contributor

sinkuu commented Jan 22, 2020

I noticed that --emit=mir takes long time on a large crate. #64344 seem to have fixed -Zdump-mir, but not --emit=mir.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 22, 2020

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jan 22, 2020

r? @Mark-Simulacrum

A quick grep for " File::create" leads me to believe there are a few more cases of this, could you fix those as well?

@ProgrammaticNajel

This comment has been minimized.

Copy link

ProgrammaticNajel commented Jan 31, 2020

Ping from triage. @Mark-Simulacrum any updates on this? Thanks.

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jan 31, 2020

Thanks, missed that a second commit was pushed. r=me once they're squashed into one.

@sinkuu sinkuu force-pushed the sinkuu:emit_mir_buffered branch from 05746e0 to 482c761 Feb 1, 2020
@sinkuu

This comment has been minimized.

Copy link
Contributor Author

sinkuu commented Feb 1, 2020

Squashed.

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Feb 1, 2020

@bors r+ rollup

Thanks!

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 1, 2020

📌 Commit 482c761 has been approved by Mark-Simulacrum

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 1, 2020
…mulacrum

Use BufWriter for emitting MIR

I noticed that `--emit=mir` takes long time on a large crate. rust-lang#64344 seem to have fixed `-Zdump-mir`, but not `--emit=mir`.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 1, 2020
…mulacrum

Use BufWriter for emitting MIR

I noticed that `--emit=mir` takes long time on a large crate. rust-lang#64344 seem to have fixed `-Zdump-mir`, but not `--emit=mir`.
bors added a commit that referenced this pull request Feb 1, 2020
Rollup of 7 pull requests

Successful merges:

 - #68460 (Use BufWriter for emitting MIR)
 - #68668 (Struct variant field search)
 - #68688 ([docs] remind bug reporters to update nightly)
 - #68704 (Ignore `build` dir formatting)
 - #68711 (Added upper bound of what vecs and boxes can allocate)
 - #68727 (Remove a comment about pretty printer in formatting tests)
 - #68740 (Do not suggest things named underscore)

Failed merges:

r? @ghost
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 1, 2020
…mulacrum

Use BufWriter for emitting MIR

I noticed that `--emit=mir` takes long time on a large crate. rust-lang#64344 seem to have fixed `-Zdump-mir`, but not `--emit=mir`.
bors added a commit that referenced this pull request Feb 1, 2020
Rollup of 7 pull requests

Successful merges:

 - #68460 (Use BufWriter for emitting MIR)
 - #68681 (Suggest path separator for single-colon typos)
 - #68688 ([docs] remind bug reporters to update nightly)
 - #68704 (Ignore `build` dir formatting)
 - #68727 (Remove a comment about pretty printer in formatting tests)
 - #68736 (Remove `Alloc` in favor of `AllocRef`)
 - #68740 (Do not suggest things named underscore)

Failed merges:

r? @ghost
@bors bors merged commit 482c761 into rust-lang:master Feb 2, 2020
4 checks passed
4 checks passed
pr Build #20200201.7 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.