Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator Resume Arguments #68524

Merged
merged 25 commits into from Feb 7, 2020
Merged

Conversation

@jonas-schievink
Copy link
Member

jonas-schievink commented Jan 24, 2020

cc #43122 and #56974

Blockers:

Follow-up work:

  • Change async/await desugaring to make use of this feature
  • Rewrite box_region.rs to use resume arguments (this shows up in profiles too)
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 24, 2020

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Jan 24, 2020

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-24T21:43:48.3705936Z ========================== Starting Command Output ===========================
2020-01-24T21:43:48.3708304Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/485d0d2f-2e2e-4090-a49d-b19aa5c328b7.sh
2020-01-24T21:43:48.3708344Z 
2020-01-24T21:43:48.3711141Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-24T21:43:48.3716855Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-24T21:43:48.3718371Z Task         : Get sources
2020-01-24T21:43:48.3718444Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-24T21:43:48.3718480Z Version      : 1.0.0
2020-01-24T21:43:48.3718517Z Author       : Microsoft
---
2020-01-24T21:43:49.1073640Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-24T21:43:49.1179369Z ##[command]git config gc.auto 0
2020-01-24T21:43:49.1280255Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-24T21:43:49.1352252Z ##[command]git config --get-all http.proxy
2020-01-24T21:43:49.1482368Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68524/merge:refs/remotes/pull/68524/merge
---
2020-01-24T21:48:47.8631386Z    Compiling serde_json v1.0.40
2020-01-24T21:48:49.2310243Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2020-01-24T21:48:57.3531078Z     Finished release [optimized] target(s) in 1m 08s
2020-01-24T21:48:57.3642273Z tidy check
2020-01-24T21:48:58.2955833Z tidy error: /checkout/src/test/ui/generator/issue-44197.rs:31: line longer than 100 chars
2020-01-24T21:48:59.8878136Z Found 487 error codes
2020-01-24T21:48:59.8878921Z Found 1 error codes with no tests
2020-01-24T21:48:59.8881918Z Done!
2020-01-24T21:48:59.8882392Z Error code E0628 needs to have at least one UI test!
2020-01-24T21:48:59.8882392Z Error code E0628 needs to have at least one UI test!
2020-01-24T21:48:59.8882671Z some tidy checks failed
2020-01-24T21:48:59.8882959Z 
2020-01-24T21:48:59.8883184Z 
2020-01-24T21:48:59.8884684Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2020-01-24T21:48:59.8885249Z 
2020-01-24T21:48:59.8885454Z 
2020-01-24T21:48:59.8890814Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2020-01-24T21:48:59.8891161Z Build completed unsuccessfully in 0:01:18
2020-01-24T21:48:59.8891161Z Build completed unsuccessfully in 0:01:18
2020-01-24T21:48:59.8943600Z == clock drift check ==
2020-01-24T21:48:59.8950767Z   local time: Fri Jan 24 21:48:59 UTC 2020
2020-01-24T21:49:00.1824835Z   network time: Fri, 24 Jan 2020 21:49:00 GMT
2020-01-24T21:49:00.1829125Z == end clock drift check ==
2020-01-24T21:49:00.9283555Z 
2020-01-24T21:49:00.9338549Z ##[error]Bash exited with code '1'.
2020-01-24T21:49:00.9349650Z ##[section]Finishing: Run build
2020-01-24T21:49:00.9362232Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-24T21:49:00.9364134Z Task         : Get sources
2020-01-24T21:49:00.9364203Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-24T21:49:00.9364254Z Version      : 1.0.0
2020-01-24T21:49:00.9364300Z Author       : Microsoft
2020-01-24T21:49:00.9364300Z Author       : Microsoft
2020-01-24T21:49:00.9364366Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-24T21:49:00.9364419Z ==============================================================================
2020-01-24T21:49:01.3187854Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-24T21:49:01.3227071Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-24T21:49:01.3333408Z Cleaning up task key
2020-01-24T21:49:01.3334278Z Start cleaning up orphan processes.
2020-01-24T21:49:01.3491820Z Terminate orphan process: pid (3761) (python)
2020-01-24T21:49:01.3669825Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Jan 24, 2020

Glad to see this implemented, but it is not my area of expertise.

r? @Zoxc for review or further reassignment.

@rust-highfive rust-highfive assigned Zoxc and unassigned petrochenkov Jan 24, 2020
@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Jan 24, 2020

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-24T22:01:33.9330209Z ========================== Starting Command Output ===========================
2020-01-24T22:01:33.9332118Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/7e0d1fea-1894-429e-ab17-80cbcb4e68f0.sh
2020-01-24T22:01:33.9332159Z 
2020-01-24T22:01:33.9335061Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-24T22:01:33.9341789Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-24T22:01:33.9343411Z Task         : Get sources
2020-01-24T22:01:33.9343441Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-24T22:01:33.9343471Z Version      : 1.0.0
2020-01-24T22:01:33.9343516Z Author       : Microsoft
---
2020-01-24T22:01:34.9093274Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-24T22:01:34.9104973Z ##[command]git config gc.auto 0
2020-01-24T22:01:34.9107091Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-24T22:01:34.9108835Z ##[command]git config --get-all http.proxy
2020-01-24T22:01:34.9115205Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68524/merge:refs/remotes/pull/68524/merge
---
2020-01-24T22:32:33.7371424Z    Compiling measureme v0.7.1
2020-01-24T22:32:40.6997121Z    Compiling rustc-rayon v0.3.0
2020-01-24T22:32:40.9884708Z    Compiling rustc_macros v0.1.0 (/checkout/src/librustc_macros)
2020-01-24T22:32:46.3380500Z    Compiling rustc_data_structures v0.0.0 (/checkout/src/librustc_data_structures)
2020-01-24T22:32:46.6131958Z error[E0191]: the value of the associated type `Resume` (from trait `std::ops::Generator`) must be specified
2020-01-24T22:32:46.6132282Z   --> src/librustc_data_structures/box_region.rs:24:28
2020-01-24T22:32:46.6132530Z    |
2020-01-24T22:32:46.6132823Z 24 |     generator: Pin<Box<dyn Generator<Yield = YieldType<I, A>, Return = R>>>,
2020-01-24T22:32:46.6133213Z    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: specify the associated type: `Generator<Yield = YieldType<I, A>, Return = R, Resume = Type>`
2020-01-24T22:32:46.6374797Z error: aborting due to previous error
2020-01-24T22:32:46.6378499Z 
2020-01-24T22:32:46.6388385Z For more information about this error, try `rustc --explain E0191`.
2020-01-24T22:32:46.6451330Z error: could not compile `rustc_data_structures`.
---
2020-01-24T22:32:55.8823146Z   local time: Fri Jan 24 22:32:55 UTC 2020
2020-01-24T22:32:56.1496931Z   network time: Fri, 24 Jan 2020 22:32:56 GMT
2020-01-24T22:32:56.1504464Z == end clock drift check ==
2020-01-24T22:32:56.9333947Z 
2020-01-24T22:32:56.9415769Z ##[error]Bash exited with code '1'.
2020-01-24T22:32:56.9426748Z ##[section]Finishing: Run build
2020-01-24T22:32:56.9449749Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-24T22:32:56.9453219Z Task         : Get sources
2020-01-24T22:32:56.9453283Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-24T22:32:56.9453326Z Version      : 1.0.0
2020-01-24T22:32:56.9453366Z Author       : Microsoft
2020-01-24T22:32:56.9453366Z Author       : Microsoft
2020-01-24T22:32:56.9453426Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-24T22:32:56.9453473Z ==============================================================================
2020-01-24T22:32:57.4425044Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-24T22:32:57.4465578Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-24T22:32:57.4582996Z Cleaning up task key
2020-01-24T22:32:57.4583791Z Start cleaning up orphan processes.
2020-01-24T22:32:57.4732435Z Terminate orphan process: pid (7106) (python)
2020-01-24T22:32:57.4985275Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/libcore/ops/generator.rs Outdated Show resolved Hide resolved
@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Jan 24, 2020

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-24T22:56:41.4393298Z ========================== Starting Command Output ===========================
2020-01-24T22:56:41.4633253Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/fcf6e515-16cb-471f-bbb7-863f981935d7.sh
2020-01-24T22:56:41.4634937Z 
2020-01-24T22:56:41.4638368Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-24T22:56:41.4645223Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-24T22:56:41.4647064Z Task         : Get sources
2020-01-24T22:56:41.4647158Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-24T22:56:41.4647200Z Version      : 1.0.0
2020-01-24T22:56:41.4647240Z Author       : Microsoft
---
2020-01-24T22:56:42.2690080Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-24T22:56:42.2698576Z ##[command]git config gc.auto 0
2020-01-24T22:56:42.2700213Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-24T22:56:42.2701524Z ##[command]git config --get-all http.proxy
2020-01-24T22:56:42.2705885Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68524/merge:refs/remotes/pull/68524/merge
---
2020-01-24T23:20:04.4074261Z    Compiling rustc_data_structures v0.0.0 (/checkout/src/librustc_data_structures)
2020-01-24T23:20:04.8217282Z error[E0061]: this function takes 1 parameter but 0 parameters were supplied
2020-01-24T23:20:04.8221216Z   --> src/librustc_data_structures/box_region.rs:53:58
2020-01-24T23:20:04.8221469Z    |
2020-01-24T23:20:04.8221729Z 53 |         let init = match Pin::new(&mut result.generator).resume() {
2020-01-24T23:20:04.8222210Z    |
2020-01-24T23:20:04.8222210Z    |
2020-01-24T23:20:04.8222436Z help: expected the unit value `()`; create it with empty parentheses
2020-01-24T23:20:04.8222631Z    |
2020-01-24T23:20:04.8223054Z 53 |         let init = match Pin::new(&mut result.generator).resume(()) {
2020-01-24T23:20:04.8223377Z 
2020-01-24T23:20:04.8267270Z error[E0061]: this function takes 1 parameter but 0 parameters were supplied
2020-01-24T23:20:04.8267566Z   --> src/librustc_data_structures/box_region.rs:67:76
2020-01-24T23:20:04.8267778Z    |
2020-01-24T23:20:04.8267778Z    |
2020-01-24T23:20:04.8268071Z 67 |         if let GeneratorState::Complete(_) = Pin::new(&mut self.generator).resume() {
2020-01-24T23:20:04.8268734Z    |
2020-01-24T23:20:04.8268734Z    |
2020-01-24T23:20:04.8268971Z help: expected the unit value `()`; create it with empty parentheses
2020-01-24T23:20:04.8269154Z    |
2020-01-24T23:20:04.8269647Z 67 |         if let GeneratorState::Complete(_) = Pin::new(&mut self.generator).resume(()) {
2020-01-24T23:20:04.8269998Z 
2020-01-24T23:20:04.8306927Z error[E0061]: this function takes 1 parameter but 0 parameters were supplied
2020-01-24T23:20:04.8307225Z   --> src/librustc_data_structures/box_region.rs:76:52
2020-01-24T23:20:04.8307415Z    |
2020-01-24T23:20:04.8307415Z    |
2020-01-24T23:20:04.8307703Z 76 |         let result = Pin::new(&mut self.generator).resume();
2020-01-24T23:20:04.8308170Z    |
2020-01-24T23:20:04.8308170Z    |
2020-01-24T23:20:04.8308400Z help: expected the unit value `()`; create it with empty parentheses
2020-01-24T23:20:04.8308580Z    |
2020-01-24T23:20:04.8308829Z 76 |         let result = Pin::new(&mut self.generator).resume(());
2020-01-24T23:20:04.8309136Z 
2020-01-24T23:20:05.2904145Z error: aborting due to 3 previous errors
2020-01-24T23:20:05.2904240Z 
2020-01-24T23:20:05.2904486Z For more information about this error, try `rustc --explain E0061`.
---
2020-01-24T23:20:12.7986935Z   local time: Fri Jan 24 23:20:12 UTC 2020
2020-01-24T23:20:13.3516644Z   network time: Fri, 24 Jan 2020 23:20:13 GMT
2020-01-24T23:20:13.3517419Z == end clock drift check ==
2020-01-24T23:20:14.1024248Z 
2020-01-24T23:20:14.1094568Z ##[error]Bash exited with code '1'.
2020-01-24T23:20:14.1108581Z ##[section]Finishing: Run build
2020-01-24T23:20:14.1127540Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-24T23:20:14.1129255Z Task         : Get sources
2020-01-24T23:20:14.1129404Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-24T23:20:14.1129462Z Version      : 1.0.0
2020-01-24T23:20:14.1129497Z Author       : Microsoft
2020-01-24T23:20:14.1129497Z Author       : Microsoft
2020-01-24T23:20:14.1129538Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-24T23:20:14.1129597Z ==============================================================================
2020-01-24T23:20:14.4731705Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-24T23:20:14.4767714Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-24T23:20:14.4853199Z Cleaning up task key
2020-01-24T23:20:14.4853859Z Start cleaning up orphan processes.
2020-01-24T23:20:14.4937182Z Terminate orphan process: pid (3845) (python)
2020-01-24T23:20:14.5100414Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@jonas-schievink jonas-schievink force-pushed the jonas-schievink:generator-resume-arguments branch from 4fa2c0e to a86373f Jan 24, 2020
@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Jan 24, 2020

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-24T23:31:31.5806338Z ========================== Starting Command Output ===========================
2020-01-24T23:31:31.5808094Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/4c852021-1676-44c1-a5a8-12242c4ae312.sh
2020-01-24T23:31:31.5808267Z 
2020-01-24T23:31:31.5810645Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-24T23:31:31.5815154Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-24T23:31:31.5816383Z Task         : Get sources
2020-01-24T23:31:31.5816409Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-24T23:31:31.5816433Z Version      : 1.0.0
2020-01-24T23:31:31.5816458Z Author       : Microsoft
---
2020-01-24T23:31:32.3727156Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-24T23:31:32.3737131Z ##[command]git config gc.auto 0
2020-01-24T23:31:32.3739093Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-24T23:31:32.3740651Z ##[command]git config --get-all http.proxy
2020-01-24T23:31:32.3745878Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68524/merge:refs/remotes/pull/68524/merge
---
2020-01-24T23:36:10.4032310Z 
2020-01-24T23:36:10.4057756Z error: could not compile `rustc_data_structures`.
2020-01-24T23:36:10.4069232Z warning: build failed, waiting for other jobs to finish...
2020-01-24T23:36:16.3190379Z error: build failed
2020-01-24T23:36:16.3209526Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "check" "-Zconfig-profile" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--color" "always" "--features" " llvm" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json-render-diagnostics"
2020-01-24T23:36:16.3220912Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap check
2020-01-24T23:36:16.3220984Z Build completed unsuccessfully in 0:02:28
2020-01-24T23:36:16.3263549Z == clock drift check ==
2020-01-24T23:36:16.3274475Z   local time: Fri Jan 24 23:36:16 UTC 2020
2020-01-24T23:36:16.3274475Z   local time: Fri Jan 24 23:36:16 UTC 2020
2020-01-24T23:36:16.4823180Z   network time: Fri, 24 Jan 2020 23:36:16 GMT
2020-01-24T23:36:16.4827750Z == end clock drift check ==
2020-01-24T23:36:17.1481592Z 
2020-01-24T23:36:17.1552850Z ##[error]Bash exited with code '1'.
2020-01-24T23:36:17.1561341Z ##[section]Finishing: Run build
2020-01-24T23:36:17.1571776Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-24T23:36:17.1573170Z Task         : Get sources
2020-01-24T23:36:17.1573206Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-24T23:36:17.1573254Z Version      : 1.0.0
2020-01-24T23:36:17.1573298Z Author       : Microsoft
2020-01-24T23:36:17.1573298Z Author       : Microsoft
2020-01-24T23:36:17.1573333Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-24T23:36:17.1573369Z ==============================================================================
2020-01-24T23:36:17.4443264Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-24T23:36:17.4488446Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-24T23:36:17.4600599Z Cleaning up task key
2020-01-24T23:36:17.4601424Z Start cleaning up orphan processes.
2020-01-24T23:36:17.4679205Z Terminate orphan process: pid (3417) (python)
2020-01-24T23:36:17.4829341Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@jonas-schievink jonas-schievink force-pushed the jonas-schievink:generator-resume-arguments branch from a86373f to 7620e7e Jan 24, 2020
@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Jan 25, 2020

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-25T00:02:47.9515794Z ========================== Starting Command Output ===========================
2020-01-25T00:02:47.9517481Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/b2319394-bd5e-4a8f-94be-a120f7e7f7e3.sh
2020-01-25T00:02:47.9517521Z 
2020-01-25T00:02:47.9522229Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-25T00:02:47.9528338Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-25T00:02:47.9530348Z Task         : Get sources
2020-01-25T00:02:47.9530380Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T00:02:47.9530411Z Version      : 1.0.0
2020-01-25T00:02:47.9530485Z Author       : Microsoft
---
2020-01-25T00:02:48.7595079Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-25T00:02:48.7697837Z ##[command]git config gc.auto 0
2020-01-25T00:02:48.7802692Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-25T00:02:48.7831709Z ##[command]git config --get-all http.proxy
2020-01-25T00:02:48.7975328Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68524/merge:refs/remotes/pull/68524/merge
---
2020-01-25T00:58:37.2792845Z .................................................................................................... 1700/9555
2020-01-25T00:58:43.2199652Z .................................................................................................... 1800/9555
2020-01-25T00:58:54.4548557Z ......................i............................................................................. 1900/9555
2020-01-25T00:59:01.1949979Z .................................................................................................... 2000/9555
2020-01-25T00:59:14.0077808Z ............iiiii................................F.................................................. 2100/9555
2020-01-25T00:59:23.2688396Z .................................................................................................... 2300/9555
2020-01-25T00:59:25.6383867Z .................................................................................................... 2400/9555
2020-01-25T00:59:30.7275746Z .................................................................................................... 2500/9555
2020-01-25T00:59:50.7852781Z .................................................................................................... 2600/9555
---
2020-01-25T01:02:25.7905215Z .............................................................i...............i...................... 4900/9555
2020-01-25T01:02:33.1981325Z .................................................................................................... 5000/9555
2020-01-25T01:02:41.0793607Z .................................................................................................... 5100/9555
2020-01-25T01:02:45.4939532Z ....i............................................................................................... 5200/9555
2020-01-25T01:02:56.5206730Z ............................................................................ii.ii........i...i...... 5300/9555
2020-01-25T01:03:05.2817734Z ..............i..................................................................................... 5500/9555
2020-01-25T01:03:14.9014859Z .................................................................................................... 5600/9555
2020-01-25T01:03:21.3596942Z ...............................................................i.................................... 5700/9555
2020-01-25T01:03:28.3392517Z .................................................................................................... 5800/9555
2020-01-25T01:03:28.3392517Z .................................................................................................... 5800/9555
2020-01-25T01:03:35.7904732Z .................................................................................................... 5900/9555
2020-01-25T01:03:44.3704807Z ......................................................ii...i..ii...........i........................ 6000/9555
2020-01-25T01:04:06.0263879Z .................................................................................................... 6200/9555
2020-01-25T01:04:14.0689062Z ......F............................................................................................. 6300/9555
2020-01-25T01:04:14.0689062Z ......F............................................................................................. 6300/9555
2020-01-25T01:04:22.3836646Z ..................................................................................i..ii............. 6400/9555
2020-01-25T01:04:48.7882481Z .................................................................................................... 6600/9555
2020-01-25T01:04:57.4651713Z ..........................................................i......................................... 6700/9555
2020-01-25T01:04:59.6731545Z .................................................................................................... 6800/9555
2020-01-25T01:05:01.8921002Z .........................................................i.......................................... 6900/9555
---
2020-01-25T01:06:41.5500308Z .................................................................................................... 7600/9555
2020-01-25T01:06:46.7954036Z .................................................................................................... 7700/9555
2020-01-25T01:06:53.5659457Z .................................................................................................... 7800/9555
2020-01-25T01:07:04.0016179Z .................................................................................................... 7900/9555
2020-01-25T01:07:09.9787894Z .............iiiiiii................................................................................ 8000/9555
2020-01-25T01:07:24.1184859Z .................................................................................................... 8200/9555
2020-01-25T01:07:34.5557876Z .................................................................................................... 8300/9555
2020-01-25T01:07:47.4507400Z .................................................................................................... 8400/9555
2020-01-25T01:07:54.1011996Z .................................................................................................... 8500/9555
---
2020-01-25T01:09:47.9824969Z ---- [ui] ui/drop/dynamic-drop.rs stdout ----
2020-01-25T01:09:47.9825328Z 
2020-01-25T01:09:47.9825974Z error: test compilation failed although it shouldn't!
2020-01-25T01:09:47.9826334Z status: exit code: 1
2020-01-25T01:09:47.9827449Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/drop/dynamic-drop.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/drop/dynamic-drop/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/drop/dynamic-drop/auxiliary"
2020-01-25T01:09:47.9828468Z ------------------------------------------
2020-01-25T01:09:47.9828790Z 
2020-01-25T01:09:47.9829375Z ------------------------------------------
2020-01-25T01:09:47.9829739Z stderr:
2020-01-25T01:09:47.9829739Z stderr:
2020-01-25T01:09:47.9830286Z ------------------------------------------
2020-01-25T01:09:47.9830632Z error[E0061]: this function takes 1 parameter but 0 parameters were supplied
2020-01-25T01:09:47.9831420Z   --> /checkout/src/test/ui/drop/dynamic-drop.rs:187:28
2020-01-25T01:09:47.9831833Z    |
2020-01-25T01:09:47.9832112Z LL |         Pin::new(&mut gen).resume();
2020-01-25T01:09:47.9833297Z    |
2020-01-25T01:09:47.9833297Z    |
2020-01-25T01:09:47.9833576Z help: expected the unit value `()`; create it with empty parentheses
2020-01-25T01:09:47.9833881Z    |
2020-01-25T01:09:47.9834146Z LL |         Pin::new(&mut gen).resume(());
2020-01-25T01:09:47.9834660Z 
2020-01-25T01:09:47.9834929Z error: aborting due to previous error
2020-01-25T01:09:47.9835156Z 
2020-01-25T01:09:47.9835809Z For more information about this error, try `rustc --explain E0061`.
---
2020-01-25T01:09:47.9839610Z -   --> $DIR/issue-55850.rs:28:9
2020-01-25T01:09:47.9840002Z + error[E0061]: this function takes 1 parameter but 0 parameters were supplied
2020-01-25T01:09:47.9840547Z +   --> $DIR/issue-55850.rs:18:37
2020-01-25T01:09:47.9840886Z 3    |
2020-01-25T01:09:47.9841443Z - LL |         yield &s[..]
2020-01-25T01:09:47.9842032Z -    |         ^^^^^^^-^^^^
2020-01-25T01:09:47.9844480Z -    |         |      `s` is borrowed here
2020-01-25T01:09:47.9845130Z -    |         yields a value referencing data owned by the current function
2020-01-25T01:09:47.9845130Z -    |         yields a value referencing data owned by the current function
2020-01-25T01:09:47.9845503Z + LL |         match Pin::new(&mut self.0).resume() {
2020-01-25T01:09:47.9846084Z 9 
2020-01-25T01:09:47.9847361Z - error[E0626]: borrow may still be in use when generator yields
2020-01-25T01:09:47.9848043Z -   --> $DIR/issue-55850.rs:28:16
2020-01-25T01:09:47.9848556Z -    |
2020-01-25T01:09:47.9848556Z -    |
2020-01-25T01:09:47.9849029Z - LL |         yield &s[..]
2020-01-25T01:09:47.9849562Z -    |         -------^---- possible yield occurs here
2020-01-25T01:09:47.9850004Z 15 
2020-01-25T01:09:47.9850479Z - error: aborting due to 2 previous errors
2020-01-25T01:09:47.9850943Z - 
2020-01-25T01:09:47.9851454Z - Some errors have detailed explanations: E0515, E0626.
2020-01-25T01:09:47.9851454Z - Some errors have detailed explanations: E0515, E0626.
2020-01-25T01:09:47.9852004Z - For more information about an error, try `rustc --explain E0515`.
2020-01-25T01:09:47.9852874Z + For more information about this error, try `rustc --explain E0061`.
2020-01-25T01:09:47.9853168Z 20 
2020-01-25T01:09:47.9853354Z 
2020-01-25T01:09:47.9853509Z 
2020-01-25T01:09:47.9853682Z The actual stderr differed from the expected stderr.
2020-01-25T01:09:47.9854215Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/nll/issue-55850/issue-55850.stderr
2020-01-25T01:09:47.9854765Z To update references, rerun the tests and pass the `--bless` flag
2020-01-25T01:09:47.9855317Z To only update this specific test, also pass `--test-args nll/issue-55850.rs`
2020-01-25T01:09:47.9857764Z error: 1 errors occurred comparing output.
2020-01-25T01:09:47.9857951Z status: exit code: 1
2020-01-25T01:09:47.9857951Z status: exit code: 1
2020-01-25T01:09:47.9859094Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/nll/issue-55850.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/nll/issue-55850" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/nll/issue-55850/auxiliary" "-A" "unused"
2020-01-25T01:09:47.9860124Z ------------------------------------------
2020-01-25T01:09:47.9860343Z 
2020-01-25T01:09:47.9860828Z ------------------------------------------
2020-01-25T01:09:47.9861225Z stderr:
2020-01-25T01:09:47.9861225Z stderr:
2020-01-25T01:09:47.9861714Z ------------------------------------------
2020-01-25T01:09:47.9861985Z error[E0061]: this function takes 1 parameter but 0 parameters were supplied
2020-01-25T01:09:47.9862896Z   --> /checkout/src/test/ui/nll/issue-55850.rs:18:37
2020-01-25T01:09:47.9863202Z    |
2020-01-25T01:09:47.9863414Z LL |         match Pin::new(&mut self.0).resume() {
2020-01-25T01:09:47.9863750Z 
2020-01-25T01:09:47.9863958Z error: aborting due to previous error
2020-01-25T01:09:47.9864108Z 
2020-01-25T01:09:47.9864611Z For more information about this error, try `rustc --explain E0061`.
---
2020-01-25T01:09:47.9869439Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:349:22
2020-01-25T01:09:47.9869679Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-01-25T01:09:47.9877425Z 
2020-01-25T01:09:47.9877784Z 
2020-01-25T01:09:47.9879834Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-25T01:09:47.9880394Z 
2020-01-25T01:09:47.9880534Z 
2020-01-25T01:09:47.9885466Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-25T01:09:47.9886059Z Build completed unsuccessfully in 1:01:27
2020-01-25T01:09:47.9886059Z Build completed unsuccessfully in 1:01:27
2020-01-25T01:09:47.9936253Z == clock drift check ==
2020-01-25T01:09:47.9955246Z   local time: Sat Jan 25 01:09:47 UTC 2020
2020-01-25T01:09:48.1545739Z   network time: Sat, 25 Jan 2020 01:09:48 GMT
2020-01-25T01:09:48.1548149Z == end clock drift check ==
2020-01-25T01:09:48.5175039Z 
2020-01-25T01:09:48.5290410Z ##[error]Bash exited with code '1'.
2020-01-25T01:09:48.5303441Z ##[section]Finishing: Run build
2020-01-25T01:09:48.5325741Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-25T01:09:48.5327709Z Task         : Get sources
2020-01-25T01:09:48.5327759Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T01:09:48.5327826Z Version      : 1.0.0
2020-01-25T01:09:48.5328024Z Author       : Microsoft
2020-01-25T01:09:48.5328024Z Author       : Microsoft
2020-01-25T01:09:48.5328071Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-25T01:09:48.5328142Z ==============================================================================
2020-01-25T01:09:48.9508505Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-25T01:09:48.9550558Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-25T01:09:48.9663171Z Cleaning up task key
2020-01-25T01:09:48.9663946Z Start cleaning up orphan processes.
2020-01-25T01:09:48.9772775Z Terminate orphan process: pid (3565) (python)
2020-01-25T01:09:49.0055554Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@jonas-schievink jonas-schievink force-pushed the jonas-schievink:generator-resume-arguments branch from 7620e7e to 239e313 Jan 25, 2020
@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Jan 25, 2020

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-25T01:36:42.4085519Z ========================== Starting Command Output ===========================
2020-01-25T01:36:42.4087413Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/bba19e82-46f8-4821-9d88-94636356daa7.sh
2020-01-25T01:36:42.4087553Z 
2020-01-25T01:36:42.4090406Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-25T01:36:42.4097146Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-25T01:36:42.4098644Z Task         : Get sources
2020-01-25T01:36:42.4098678Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T01:36:42.4098754Z Version      : 1.0.0
2020-01-25T01:36:42.4098787Z Author       : Microsoft
---
2020-01-25T01:36:43.4091318Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-25T01:36:43.4103105Z ##[command]git config gc.auto 0
2020-01-25T01:36:43.4105715Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-25T01:36:43.4107906Z ##[command]git config --get-all http.proxy
2020-01-25T01:36:43.4114765Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68524/merge:refs/remotes/pull/68524/merge
---
2020-01-25T02:18:32.9833701Z .................................................................................................... 1700/9555
2020-01-25T02:18:38.5721889Z .................................................................................................... 1800/9555
2020-01-25T02:18:48.9488290Z ......................i............................................................................. 1900/9555
2020-01-25T02:18:55.2839086Z .................................................................................................... 2000/9555
2020-01-25T02:19:07.9959695Z ............iiiii................................................................................... 2100/9555
2020-01-25T02:19:16.2225492Z .................................................................................................... 2300/9555
2020-01-25T02:19:18.2608670Z .................................................................................................... 2400/9555
2020-01-25T02:19:22.8398220Z .................................................................................................... 2500/9555
2020-01-25T02:19:40.4977469Z .................................................................................................... 2600/9555
---
2020-01-25T02:21:57.0002972Z .............................................................i...............i...................... 4900/9555
2020-01-25T02:22:03.7525386Z .................................................................................................... 5000/9555
2020-01-25T02:22:10.6921549Z .................................................................................................... 5100/9555
2020-01-25T02:22:14.6915999Z ....i............................................................................................... 5200/9555
2020-01-25T02:22:24.2273994Z ............................................................................ii.ii........i...i...... 5300/9555
2020-01-25T02:22:31.8772980Z ..............i..................................................................................... 5500/9555
2020-01-25T02:22:40.7162932Z .................................................................................................... 5600/9555
2020-01-25T02:22:46.3263404Z ...............................................................i.................................... 5700/9555
2020-01-25T02:22:52.3466772Z .................................................................................................... 5800/9555
2020-01-25T02:22:52.3466772Z .................................................................................................... 5800/9555
2020-01-25T02:22:59.0874476Z .................................................................................................... 5900/9555
2020-01-25T02:23:07.3084705Z ......................................................ii...i..ii...........i........................ 6000/9555
2020-01-25T02:23:25.8994249Z .................................................................................................... 6200/9555
2020-01-25T02:23:29.8933342Z ........F........................................................................................... 6300/9555
2020-01-25T02:23:29.8933342Z ........F........................................................................................... 6300/9555
2020-01-25T02:23:33.8507843Z ..................................................................................i..ii............. 6400/9555
2020-01-25T02:23:54.8623917Z .................................................................................................... 6600/9555
2020-01-25T02:24:02.3200444Z ..........................................................i......................................... 6700/9555
2020-01-25T02:24:04.2577405Z .................................................................................................... 6800/9555
2020-01-25T02:24:06.2054620Z .........................................................i.......................................... 6900/9555
---
2020-01-25T02:25:31.9546447Z .................................................................................................... 7600/9555
2020-01-25T02:25:36.5451707Z .................................................................................................... 7700/9555
2020-01-25T02:25:42.1790548Z .................................................................................................... 7800/9555
2020-01-25T02:25:51.1792857Z .................................................................................................... 7900/9555
2020-01-25T02:25:56.4224553Z .............iiiiiii................................................................................ 8000/9555
2020-01-25T02:26:08.4530077Z .................................................................................................... 8200/9555
2020-01-25T02:26:17.4691938Z .................................................................................................... 8300/9555
2020-01-25T02:26:28.6333637Z .................................................................................................... 8400/9555
2020-01-25T02:26:34.2219958Z .................................................................................................... 8500/9555
---
2020-01-25T02:28:09.4936458Z -   --> $DIR/issue-55850.rs:28:9
2020-01-25T02:28:09.4936524Z + error[E0308]: mismatched types
2020-01-25T02:28:09.4936719Z +   --> $DIR/issue-55850.rs:18:44
2020-01-25T02:28:09.4936763Z 3    |
2020-01-25T02:28:09.4936965Z - LL |         yield &s[..]
2020-01-25T02:28:09.4937150Z -    |         ^^^^^^^-^^^^
2020-01-25T02:28:09.4937552Z -    |         |      `s` is borrowed here
2020-01-25T02:28:09.4937786Z -    |         yields a value referencing data owned by the current function
2020-01-25T02:28:09.4938103Z - 
2020-01-25T02:28:09.4939139Z - error[E0626]: borrow may still be in use when generator yields
2020-01-25T02:28:09.4939139Z - error[E0626]: borrow may still be in use when generator yields
2020-01-25T02:28:09.4939608Z -   --> $DIR/issue-55850.rs:28:16
2020-01-25T02:28:09.4939826Z + LL |         match Pin::new(&mut self.0).resume(()) {
2020-01-25T02:28:09.4940042Z +    |                                            ^^ expected associated type, found `()`
2020-01-25T02:28:09.4940229Z 12    |
2020-01-25T02:28:09.4940597Z - LL |         yield &s[..]
2020-01-25T02:28:09.4940987Z -    |         -------^---- possible yield occurs here
2020-01-25T02:28:09.4941202Z +    = note: expected associated type `<G as std::ops::Generator>::Resume`
2020-01-25T02:28:09.4941411Z +                     found unit type `()`
2020-01-25T02:28:09.4941610Z +    = note: consider constraining the associated type `<G as std::ops::Generator>::Resume` to `()` or calling a method that returns `<G as std::ops::Generator>::Resume`
2020-01-25T02:28:09.4942280Z 15 
2020-01-25T02:28:09.4942640Z - error: aborting due to 2 previous errors
2020-01-25T02:28:09.4943054Z + error: aborting due to previous error
2020-01-25T02:28:09.4943258Z 17 
---
2020-01-25T02:28:09.4948672Z 
2020-01-25T02:28:09.4948783Z 
2020-01-25T02:28:09.4948912Z The actual stderr differed from the expected stderr.
2020-01-25T02:28:09.4949311Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/nll/issue-55850/issue-55850.stderr
2020-01-25T02:28:09.4949849Z To update references, rerun the tests and pass the `--bless` flag
2020-01-25T02:28:09.4950223Z To only update this specific test, also pass `--test-args nll/issue-55850.rs`
2020-01-25T02:28:09.4950474Z error: 1 errors occurred comparing output.
2020-01-25T02:28:09.4950630Z status: exit code: 1
2020-01-25T02:28:09.4950630Z status: exit code: 1
2020-01-25T02:28:09.4951464Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/nll/issue-55850.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/nll/issue-55850" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/nll/issue-55850/auxiliary" "-A" "unused"
2020-01-25T02:28:09.4951973Z ------------------------------------------
2020-01-25T02:28:09.4952113Z 
2020-01-25T02:28:09.4952410Z ------------------------------------------
2020-01-25T02:28:09.4952545Z stderr:
2020-01-25T02:28:09.4952545Z stderr:
2020-01-25T02:28:09.4952851Z ------------------------------------------
2020-01-25T02:28:09.4952994Z error[E0308]: mismatched types
2020-01-25T02:28:09.4953326Z   --> /checkout/src/test/ui/nll/issue-55850.rs:18:44
2020-01-25T02:28:09.4953480Z    |
2020-01-25T02:28:09.4953607Z LL |         match Pin::new(&mut self.0).resume(()) {
2020-01-25T02:28:09.4953740Z    |                                            ^^ expected associated type, found `()`
2020-01-25T02:28:09.4953881Z    |
2020-01-25T02:28:09.4954011Z    = note: expected associated type `<G as std::ops::Generator>::Resume`
2020-01-25T02:28:09.4954157Z                     found unit type `()`
2020-01-25T02:28:09.4954308Z    = note: consider constraining the associated type `<G as std::ops::Generator>::Resume` to `()` or calling a method that returns `<G as std::ops::Generator>::Resume`
2020-01-25T02:28:09.4956011Z 
2020-01-25T02:28:09.4956094Z error: aborting due to previous error
2020-01-25T02:28:09.4956187Z 
2020-01-25T02:28:09.4956476Z For more information about this error, try `rustc --explain E0308`.
---
2020-01-25T02:28:09.4957728Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:349:22
2020-01-25T02:28:09.4957800Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-01-25T02:28:09.4957834Z 
2020-01-25T02:28:09.4957876Z 
2020-01-25T02:28:09.4959608Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-25T02:28:09.4959938Z 
2020-01-25T02:28:09.4959968Z 
2020-01-25T02:28:09.4963763Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-25T02:28:09.4963851Z Build completed unsuccessfully in 0:46:33
2020-01-25T02:28:09.4963851Z Build completed unsuccessfully in 0:46:33
2020-01-25T02:28:09.5015170Z == clock drift check ==
2020-01-25T02:28:09.5036563Z   local time: Sat Jan 25 02:28:09 UTC 2020
2020-01-25T02:28:09.8019183Z   network time: Sat, 25 Jan 2020 02:28:09 GMT
2020-01-25T02:28:09.8022853Z == end clock drift check ==
2020-01-25T02:28:10.4444923Z 
2020-01-25T02:28:10.4538708Z ##[error]Bash exited with code '1'.
2020-01-25T02:28:10.4549477Z ##[section]Finishing: Run build
2020-01-25T02:28:10.4567745Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-25T02:28:10.4569506Z Task         : Get sources
2020-01-25T02:28:10.4569556Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T02:28:10.4569603Z Version      : 1.0.0
2020-01-25T02:28:10.4569659Z Author       : Microsoft
2020-01-25T02:28:10.4569659Z Author       : Microsoft
2020-01-25T02:28:10.4569705Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-25T02:28:10.4569754Z ==============================================================================
2020-01-25T02:28:10.8432744Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-25T02:28:10.8476981Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-25T02:28:10.8575159Z Cleaning up task key
2020-01-25T02:28:10.8575918Z Start cleaning up orphan processes.
2020-01-25T02:28:10.8667912Z Terminate orphan process: pid (3721) (python)
2020-01-25T02:28:10.8866375Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@jonas-schievink jonas-schievink force-pushed the jonas-schievink:generator-resume-arguments branch from 239e313 to 6795f59 Jan 25, 2020
@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Jan 25, 2020

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-25T03:08:19.9312758Z ========================== Starting Command Output ===========================
2020-01-25T03:08:19.9316798Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/207faf66-3293-4036-8f18-c892036ea5e8.sh
2020-01-25T03:08:19.9316841Z 
2020-01-25T03:08:19.9319630Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-25T03:08:19.9326135Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-25T03:08:19.9327783Z Task         : Get sources
2020-01-25T03:08:19.9327822Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T03:08:19.9327898Z Version      : 1.0.0
2020-01-25T03:08:19.9327938Z Author       : Microsoft
---
2020-01-25T03:08:20.7593026Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-25T03:08:20.7696158Z ##[command]git config gc.auto 0
2020-01-25T03:08:20.7793697Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-25T03:08:20.7843734Z ##[command]git config --get-all http.proxy
2020-01-25T03:08:20.8004540Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68524/merge:refs/remotes/pull/68524/merge
---
2020-01-25T04:00:15.7495894Z .................................................................................................... 1700/9556
2020-01-25T04:00:21.4428697Z .................................................................................................... 1800/9556
2020-01-25T04:00:32.6201896Z .......................i............................................................................ 1900/9556
2020-01-25T04:00:39.3335822Z .................................................................................................... 2000/9556
2020-01-25T04:00:53.0515162Z .............iiiii.................................................................................. 2100/9556
2020-01-25T04:01:02.2704924Z .................................................................................................... 2300/9556
2020-01-25T04:01:04.6265118Z .................................................................................................... 2400/9556
2020-01-25T04:01:09.7219218Z .................................................................................................... 2500/9556
2020-01-25T04:01:29.2757648Z .................................................................................................... 2600/9556
---
2020-01-25T04:03:59.7071937Z ..............................................................i...............i..................... 4900/9556
2020-01-25T04:04:06.9149233Z .................................................................................................... 5000/9556
2020-01-25T04:04:14.6303437Z .................................................................................................... 5100/9556
2020-01-25T04:04:19.0602967Z .....i.............................................................................................. 5200/9556
2020-01-25T04:04:29.5062129Z .............................................................................ii.ii........i...i..... 5300/9556
2020-01-25T04:04:37.5348278Z ...............i.................................................................................... 5500/9556
2020-01-25T04:04:46.4185140Z .................................................................................................... 5600/9556
2020-01-25T04:04:53.4360792Z ................................................................i................................... 5700/9556
2020-01-25T04:04:59.4673990Z .................................................................................................... 5800/9556
2020-01-25T04:04:59.4673990Z .................................................................................................... 5800/9556
2020-01-25T04:05:06.6011900Z .................................................................................................... 5900/9556
2020-01-25T04:05:15.0516004Z .......................................................ii...i..ii...........i....................... 6000/9556
2020-01-25T04:05:36.3404141Z .................................................................................................... 6200/9556
2020-01-25T04:05:42.1337409Z .................................................................................................... 6300/9556
2020-01-25T04:05:42.1337409Z .................................................................................................... 6300/9556
2020-01-25T04:05:46.1804217Z ...................................................................................i..ii............ 6400/9556
2020-01-25T04:06:08.4748586Z .................................................................................................... 6600/9556
2020-01-25T04:06:16.5435583Z ...........................................................i........................................ 6700/9556
2020-01-25T04:06:18.6752993Z .................................................................................................... 6800/9556
2020-01-25T04:06:20.8118935Z ..........................................................i......................................... 6900/9556
---
2020-01-25T04:07:54.9691210Z .................................................................................................... 7600/9556
2020-01-25T04:08:00.2029784Z .................................................................................................... 7700/9556
2020-01-25T04:08:06.6594955Z .................................................................................................... 7800/9556
2020-01-25T04:08:17.2968033Z .................................................................................................... 7900/9556
2020-01-25T04:08:23.2974084Z ..............iiiiiii............................................................................... 8000/9556
2020-01-25T04:08:37.2646936Z .................................................................................................... 8200/9556
2020-01-25T04:08:47.4538747Z .................................................................................................... 8300/9556
2020-01-25T04:09:00.2532206Z .................................................................................................... 8400/9556
2020-01-25T04:09:06.6937614Z .................................................................................................... 8500/9556
---
2020-01-25T04:11:10.4639800Z ---- [run-fail] run-fail/generator-resume-after-panic.rs stdout ----
2020-01-25T04:11:10.4639949Z 
2020-01-25T04:11:10.4640097Z error: compilation failed!
2020-01-25T04:11:10.4640254Z status: exit code: 1
2020-01-25T04:11:10.4641529Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-fail/generator-resume-after-panic.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-fail/generator-resume-after-panic/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-fail/generator-resume-after-panic/auxiliary"
2020-01-25T04:11:10.4642194Z ------------------------------------------
2020-01-25T04:11:10.4642337Z 
2020-01-25T04:11:10.4642695Z ------------------------------------------
2020-01-25T04:11:10.4642853Z stderr:
---
2020-01-25T04:11:10.4645644Z 
2020-01-25T04:11:10.4645807Z error[E0061]: this function takes 1 parameter but 0 parameters were supplied
2020-01-25T04:11:10.4646176Z   --> /checkout/src/test/run-fail/generator-resume-after-panic.rs:19:34
2020-01-25T04:11:10.4646346Z    |
2020-01-25T04:11:10.4646487Z 19 |         let x = Pin::new(&mut g).resume();
2020-01-25T04:11:10.4646789Z    |
2020-01-25T04:11:10.4646789Z    |
2020-01-25T04:11:10.4646929Z help: expected the unit value `()`; create it with empty parentheses
2020-01-25T04:11:10.4647065Z    |
2020-01-25T04:11:10.4647219Z 19 |         let x = Pin::new(&mut g).resume(());
2020-01-25T04:11:10.4647477Z 
2020-01-25T04:11:10.4647637Z error[E0061]: this function takes 1 parameter but 0 parameters were supplied
2020-01-25T04:11:10.4648015Z   --> /checkout/src/test/run-fail/generator-resume-after-panic.rs:21:22
2020-01-25T04:11:10.4648397Z    |
2020-01-25T04:11:10.4648397Z    |
2020-01-25T04:11:10.4648584Z 21 |     Pin::new(&mut g).resume();
2020-01-25T04:11:10.4649055Z    |
2020-01-25T04:11:10.4649055Z    |
2020-01-25T04:11:10.4649223Z help: expected the unit value `()`; create it with empty parentheses
2020-01-25T04:11:10.4649357Z    |
2020-01-25T04:11:10.4649508Z 21 |     Pin::new(&mut g).resume(());
2020-01-25T04:11:10.4649780Z 
2020-01-25T04:11:10.4649916Z error: aborting due to 2 previous errors
2020-01-25T04:11:10.4650050Z 
2020-01-25T04:11:10.4650468Z For more information about this error, try `rustc --explain E0061`.
---
2020-01-25T04:11:10.4653065Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:349:22
2020-01-25T04:11:10.4653254Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-01-25T04:11:10.4653378Z 
2020-01-25T04:11:10.4653494Z 
2020-01-25T04:11:10.4655406Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-fail" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-fail" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-fail" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-25T04:11:10.4655857Z 
2020-01-25T04:11:10.4655996Z 
2020-01-25T04:11:10.4656137Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-25T04:11:10.4656281Z Build completed unsuccessfully in 0:57:22
2020-01-25T04:11:10.4656281Z Build completed unsuccessfully in 0:57:22
2020-01-25T04:11:10.4707584Z == clock drift check ==
2020-01-25T04:11:10.4725215Z   local time: Sat Jan 25 04:11:10 UTC 2020
2020-01-25T04:11:10.7624115Z   network time: Sat, 25 Jan 2020 04:11:10 GMT
2020-01-25T04:11:10.7635485Z == end clock drift check ==
2020-01-25T04:11:11.2206012Z 
2020-01-25T04:11:11.2301952Z ##[error]Bash exited with code '1'.
2020-01-25T04:11:11.2313975Z ##[section]Finishing: Run build
2020-01-25T04:11:11.2335413Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-25T04:11:11.2337389Z Task         : Get sources
2020-01-25T04:11:11.2337458Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T04:11:11.2337509Z Version      : 1.0.0
2020-01-25T04:11:11.2337555Z Author       : Microsoft
2020-01-25T04:11:11.2337555Z Author       : Microsoft
2020-01-25T04:11:11.2337622Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-25T04:11:11.2337677Z ==============================================================================
2020-01-25T04:11:11.6412488Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-25T04:11:11.6454111Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68524/merge to s
2020-01-25T04:11:11.6579020Z Cleaning up task key
2020-01-25T04:11:11.6579856Z Start cleaning up orphan processes.
2020-01-25T04:11:11.6683579Z Terminate orphan process: pid (3902) (python)
2020-01-25T04:11:11.7029714Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@jonas-schievink jonas-schievink force-pushed the jonas-schievink:generator-resume-arguments branch from 6795f59 to b1944ab Jan 25, 2020
TerminatorKind::Yield { ref value, .. } => {
TerminatorKind::Yield { ref value, resume_arg: ref place, .. } => {
self.create_move_path(place);
self.gather_init(place.as_ref(), InitKind::Deep);

This comment has been minimized.

Copy link
@Zoxc

Zoxc Jan 25, 2020

Contributor

I noticed that the order of gather_init and gather_operand is swapped compared to DropAndReplace, but I'm not sure if it matters.

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Jan 25, 2020

I think I'd prefer to make this PR make the argument be a type parameter instead of a associated type before landing to avoid some unnecessary churn in the compiler and for users of generators.

I also don't know how correct this is with regards to drops and references, but those concerns could be delayed by just adding a 'static + Copy bound to the generator argument in typeck. That would be good enough for async/await.

@bjorn3

This comment has been minimized.

Copy link
Contributor

bjorn3 commented Jan 25, 2020

I think an assocated type makes more sense, as it is very unlikely to ever be overloaded for different resume types.

@matthewjasper

This comment has been minimized.

Copy link
Contributor

matthewjasper commented Jan 25, 2020

Async generators (should) implement for<'a, 'b> Geneator<&'a Context<'b>, Yield = ()>, which needs a type parameter.

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Feb 6, 2020

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 6, 2020

📌 Commit 732913a has been approved by Zoxc

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 6, 2020

⌛️ Testing commit 732913a with merge 003534d...

bors added a commit that referenced this pull request Feb 6, 2020
…Zoxc

Generator Resume Arguments

cc #43122 and #56974

Blockers:
* [x] Fix miscompilation when resume argument is live across a yield point (#68524 (comment))
* [x] Fix 10% compile time regression in `await-call-tree` benchmarks (#68524 (comment))
  * [x] Fix remaining 1-3% regression (#68524 (comment)) - resolved (#68524 (comment))
* [x] Make dropck rules account for resume arguments (#68524 (comment))

Follow-up work:
* Change async/await desugaring to make use of this feature
* Rewrite [`box_region.rs`](https://github.com/rust-lang/rust/blob/3d8778d767f0dde6fe2bc9459f21ead8e124d8cb/src/librustc_data_structures/box_region.rs) to use resume arguments (this shows up in profiles too)
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 6, 2020

The job test-various of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-02-06T13:52:01.9587157Z ---- [ui] ui/generator/panic-drops-resume.rs stdout ----
2020-02-06T13:52:01.9587212Z 
2020-02-06T13:52:01.9587293Z error: test run failed!
2020-02-06T13:52:01.9587372Z status: exit code: 101
2020-02-06T13:52:01.9588102Z command: "/node-v9.2.0-linux-x64/bin/node" "/checkout/src/etc/wasm32-shim.js" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/generator/panic-drops-resume/a.wasm"
2020-02-06T13:52:01.9588433Z ------------------------------------------
2020-02-06T13:52:01.9588492Z 
2020-02-06T13:52:01.9588691Z ------------------------------------------
2020-02-06T13:52:01.9588781Z stderr:
2020-02-06T13:52:01.9588781Z stderr:
2020-02-06T13:52:01.9588977Z ------------------------------------------
2020-02-06T13:52:01.9589056Z RuntimeError: unreachable
2020-02-06T13:52:01.9589268Z     at __rust_start_panic (wasm-function[67]:1)
2020-02-06T13:52:01.9589494Z     at rust_panic (wasm-function[62]:39)
2020-02-06T13:52:01.9589754Z     at _ZN3std9panicking20rust_panic_with_hook17hce0078af59cd6d68E (wasm-function[57]:279)
2020-02-06T13:52:01.9590209Z     at _ZN3std9panicking11begin_panic17ha296b5396bccef14E (wasm-function[1]:55)
2020-02-06T13:52:01.9590565Z     at _ZN3std9panicking3try7do_call17h8f1195c9f0dbdb86E.llvm.13732214386119929706 (wasm-function[2]:54)
2020-02-06T13:52:01.9590844Z     at __rust_maybe_catch_panic (wasm-function[66]:5)
2020-02-06T13:52:01.9591137Z     at _ZN18panic_drops_resume4main17h1e3758f93406ae49E (wasm-function[6]:104)
2020-02-06T13:52:01.9591440Z     at _ZN3std2rt10lang_start28_$u7b$$u7b$closure$u7d$$u7d$17h2edd8568de8eb571E (wasm-function[9]:25)
2020-02-06T13:52:01.9591780Z     at _ZN3std10sys_common9backtrace28__rust_begin_short_backtrace17heaab70e414a5f765E (wasm-function[46]:8)
2020-02-06T13:52:01.9592063Z     at _ZN3std9panicking3try7do_call17ha70e32415386bc04E (wasm-function[55]:20)
2020-02-06T13:52:01.9592333Z     at __rust_maybe_catch_panic (wasm-function[66]:5)
2020-02-06T13:52:01.9592625Z     at _ZN3std2rt19lang_start_internal17h3636b7b998119f22E (wasm-function[63]:250)
2020-02-06T13:52:01.9592854Z     at main (wasm-function[7]:46)
2020-02-06T13:52:01.9593119Z     at Object.<anonymous> (/checkout/src/etc/wasm32-shim.js:20:20)
2020-02-06T13:52:01.9593192Z     at Module._compile (module.js:641:30)
2020-02-06T13:52:01.9593285Z     at Object.Module._extensions..js (module.js:652:10)
2020-02-06T13:52:01.9593351Z     at Module.load (module.js:560:32)
2020-02-06T13:52:01.9593429Z     at tryModuleLoad (module.js:503:12)
2020-02-06T13:52:01.9593494Z     at Function.Module._load (module.js:495:3)
2020-02-06T13:52:01.9593580Z     at Function.Module.runMain (module.js:682:10)
2020-02-06T13:52:01.9594250Z ------------------------------------------
2020-02-06T13:52:01.9594292Z 
2020-02-06T13:52:01.9594322Z 
2020-02-06T13:52:01.9594580Z 
---
2020-02-06T13:52:01.9608846Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-02-06T13:52:01.9609117Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-06T13:52:01.9620689Z 
2020-02-06T13:52:01.9621623Z 
2020-02-06T13:52:01.9624749Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/wasm32-unknown-unknown/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-wasm32-unknown-unknown" "--mode" "ui" "--target" "wasm32-unknown-unknown" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--nodejs" "/node-v9.2.0-linux-x64/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/wasm32-unknown-unknown/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "9.0.1-rust-1.43.0-nightly\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-02-06T13:52:01.9625434Z 
2020-02-06T13:52:01.9625470Z 
2020-02-06T13:52:01.9640853Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target wasm32-unknown-unknown src/test/run-make src/test/ui src/test/compile-fail src/test/mir-opt src/test/codegen-units src/libcore
2020-02-06T13:52:01.9640994Z Build completed unsuccessfully in 1:23:16
2020-02-06T13:52:01.9640994Z Build completed unsuccessfully in 1:23:16
2020-02-06T13:52:01.9726413Z == clock drift check ==
2020-02-06T13:52:01.9747262Z   local time: Thu Feb  6 13:52:01 UTC 2020
2020-02-06T13:52:02.2444294Z   network time: Thu, 06 Feb 2020 13:52:02 GMT
2020-02-06T13:52:02.2447529Z == end clock drift check ==
2020-02-06T13:52:03.0771375Z 
2020-02-06T13:52:03.0863751Z ##[error]Bash exited with code '1'.
2020-02-06T13:52:03.0905866Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2020-02-06T13:52:03.0908159Z ==============================================================================
2020-02-06T13:52:03.0908227Z Task         : Get sources
2020-02-06T13:52:03.0908305Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 6, 2020

💔 Test failed - checks-azure

@jonas-schievink jonas-schievink force-pushed the jonas-schievink:generator-resume-arguments branch from 01de4ae to 9d7b214 Feb 6, 2020
It does not have unwinding support
@jonas-schievink

This comment has been minimized.

Copy link
Member Author

jonas-schievink commented Feb 6, 2020

@bors r=Zoxc

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 6, 2020

📌 Commit 9d7b214 has been approved by Zoxc

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 6, 2020
…guments, r=Zoxc

Generator Resume Arguments

cc rust-lang#43122 and rust-lang#56974

Blockers:
* [x] Fix miscompilation when resume argument is live across a yield point (rust-lang#68524 (comment))
* [x] Fix 10% compile time regression in `await-call-tree` benchmarks (rust-lang#68524 (comment))
  * [x] Fix remaining 1-3% regression (rust-lang#68524 (comment)) - resolved (rust-lang#68524 (comment))
* [x] Make dropck rules account for resume arguments (rust-lang#68524 (comment))

Follow-up work:
* Change async/await desugaring to make use of this feature
* Rewrite [`box_region.rs`](https://github.com/rust-lang/rust/blob/3d8778d767f0dde6fe2bc9459f21ead8e124d8cb/src/librustc_data_structures/box_region.rs) to use resume arguments (this shows up in profiles too)
bors added a commit that referenced this pull request Feb 7, 2020
Rollup of 6 pull requests

Successful merges:

 - #67359 (Rename -Zexternal-macro-backtrace to -Zmacro-backtrace and clean up implementation.)
 - #68524 (Generator Resume Arguments)
 - #68791 (implement proper linkchecker hardening)
 - #68886 (Mark fn map_or() as eagerly evaluated.)
 - #68888 (error code examples: replace some more ignore with compile_fail)
 - #68894 (Update E0565 examples)

Failed merges:

r? @ghost
@bors bors merged commit 9d7b214 into rust-lang:master Feb 7, 2020
4 checks passed
4 checks passed
pr Build #20200206.25 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@semtexzv

This comment has been minimized.

Copy link

semtexzv commented Feb 12, 2020

@jonas-schievink Thanks for the change, I'd be interested about how it relates to the discussion in rust-lang/rfcs#2781 , I'd love to have your input :)

@jonas-schievink

This comment has been minimized.

Copy link
Member Author

jonas-schievink commented Feb 12, 2020

@semtexzv I don't really have the energy to partake in RFC discussions, but I seem to have implemented the second option described in rust-lang/rfcs#2781 (comment) in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.