Generator Resume Arguments #68524
Merged
Generator Resume Arguments #68524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
jonas-schievink
added
A-generators
F-generators
WG-embedded
S-waiting-on-review
and removed
S-waiting-on-review
labels
This was referenced Jan 24, 2020
This comment has been minimized.
This comment has been minimized.
|
Glad to see this implemented, but it is not my area of expertise. r? @Zoxc for review or further reassignment. |
This comment has been minimized.
This comment has been minimized.
cramertj
reviewed
Jan 24, 2020
This comment has been minimized.
This comment has been minimized.
jonas-schievink
force-pushed
the
generator-resume-arguments
branch
from
4fa2c0e
to
a86373f
Compare
This comment has been minimized.
This comment has been minimized.
jonas-schievink
force-pushed
the
generator-resume-arguments
branch
from
a86373f
to
7620e7e
Compare
This comment has been minimized.
This comment has been minimized.
jonas-schievink
force-pushed
the
generator-resume-arguments
branch
from
7620e7e
to
239e313
Compare
This comment has been minimized.
This comment has been minimized.
jonas-schievink
force-pushed
the
generator-resume-arguments
branch
from
239e313
to
6795f59
Compare
This comment has been minimized.
This comment has been minimized.
jonas-schievink
force-pushed
the
generator-resume-arguments
branch
from
6795f59
to
b1944ab
Compare
Zoxc
reviewed
Jan 25, 2020
| TerminatorKind::Yield { ref value, .. } => { | ||
| TerminatorKind::Yield { ref value, resume_arg: ref place, .. } => { | ||
| self.create_move_path(place); | ||
| self.gather_init(place.as_ref(), InitKind::Deep); |
There was a problem hiding this comment.
I noticed that the order of gather_init and gather_operand is swapped compared to DropAndReplace, but I'm not sure if it matters.
|
I think I'd prefer to make this PR make the argument be a type parameter instead of a associated type before landing to avoid some unnecessary churn in the compiler and for users of generators. I also don't know how correct this is with regards to drops and references, but those concerns could be delayed by just adding a |
|
I think an assocated type makes more sense, as it is very unlikely to ever be overloaded for different resume types. |
|
Async generators (should) implement |
|
|
bors
added a commit
that referenced
this issue
Feb 6, 2020
…Zoxc Generator Resume Arguments cc #43122 and #56974 Blockers: * [x] Fix miscompilation when resume argument is live across a yield point (#68524 (comment)) * [x] Fix 10% compile time regression in `await-call-tree` benchmarks (#68524 (comment)) * [x] Fix remaining 1-3% regression (#68524 (comment)) - resolved (#68524 (comment)) * [x] Make dropck rules account for resume arguments (#68524 (comment)) Follow-up work: * Change async/await desugaring to make use of this feature * Rewrite [`box_region.rs`](https://github.com/rust-lang/rust/blob/3d8778d767f0dde6fe2bc9459f21ead8e124d8cb/src/librustc_data_structures/box_region.rs) to use resume arguments (this shows up in profiles too)
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
|
jonas-schievink
force-pushed
the
generator-resume-arguments
branch
from
01de4ae
to
9d7b214
Compare
It does not have unwinding support
|
@bors r=Zoxc |
|
|
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Feb 6, 2020
…guments, r=Zoxc Generator Resume Arguments cc rust-lang#43122 and rust-lang#56974 Blockers: * [x] Fix miscompilation when resume argument is live across a yield point (rust-lang#68524 (comment)) * [x] Fix 10% compile time regression in `await-call-tree` benchmarks (rust-lang#68524 (comment)) * [x] Fix remaining 1-3% regression (rust-lang#68524 (comment)) - resolved (rust-lang#68524 (comment)) * [x] Make dropck rules account for resume arguments (rust-lang#68524 (comment)) Follow-up work: * Change async/await desugaring to make use of this feature * Rewrite [`box_region.rs`](https://github.com/rust-lang/rust/blob/3d8778d767f0dde6fe2bc9459f21ead8e124d8cb/src/librustc_data_structures/box_region.rs) to use resume arguments (this shows up in profiles too)
bors
added a commit
that referenced
this issue
Feb 7, 2020
Rollup of 6 pull requests Successful merges: - #67359 (Rename -Zexternal-macro-backtrace to -Zmacro-backtrace and clean up implementation.) - #68524 (Generator Resume Arguments) - #68791 (implement proper linkchecker hardening) - #68886 (Mark fn map_or() as eagerly evaluated.) - #68888 (error code examples: replace some more ignore with compile_fail) - #68894 (Update E0565 examples) Failed merges: r? @ghost
This was referenced Feb 7, 2020
|
@jonas-schievink Thanks for the change, I'd be interested about how it relates to the discussion in rust-lang/rfcs#2781 , I'd love to have your input :) |
|
@semtexzv I don't really have the energy to partake in RFC discussions, but I seem to have implemented the second option described in rust-lang/rfcs#2781 (comment) in this PR |
|
@jonas-schievink as far as I can tell, this PR doesn't introduce any generator syntax for defining the types of resume arguments and yield values. It still relies on type inference to get those types, right? What would a maximally qualified generator look like now? Something like this?: |
|
@pitaj The resume argument works like a closure argument, you can give it an explicit type like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
cc #43122 and #56974
Blockers:
await-call-treebenchmarks (#68524 (comment))Follow-up work:
box_region.rsto use resume arguments (this shows up in profiles too)