Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upStruct variant field search #68668
Open
Struct variant field search #68668
+48
−24
Conversation
On the backend, rustdoc now emits `paths` entries to a crate's search index for struct-like enum variants, and index items of type structfield which belong to such variants point to their variant parents in the `paths` table, rather than their enum grandparents. The path entry for a variant is the fully qualified module path plus the enum name. On the frontend, the search code recognizes structfields belonging to structlike variants in the `paths` table and re-constructs the URL to the field's anchor on the enum documentation page. closes #16017
This comment has been minimized.
This comment has been minimized.
|
I've built and verified this works against a local trivial test case. For some reason I failed to run the JS tests locally, I must be missing something. |
|
The change looks sane, though as I said I can't verify the test case per-se |
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Feb 1, 2020
…-search, r=kinnison Struct variant field search Fixes rust-lang#16017. Reopening of rust-lang#64724. cc @tomjakubowski cc @ollie27 r? @kinnison
bors
added a commit
that referenced
this pull request
Feb 1, 2020
This comment has been minimized.
This comment has been minimized.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 1, 2020
…-search, r=kinnison Struct variant field search Fixes rust-lang#16017. Reopening of rust-lang#64724. cc @tomjakubowski cc @ollie27 r? @kinnison
This comment has been minimized.
This comment has been minimized.
|
@bors retry rolledup |
bors
added a commit
that referenced
this pull request
Feb 1, 2020
Rollup of 7 pull requests Successful merges: - #68460 (Use BufWriter for emitting MIR) - #68668 (Struct variant field search) - #68688 ([docs] remind bug reporters to update nightly) - #68704 (Ignore `build` dir formatting) - #68711 (Added upper bound of what vecs and boxes can allocate) - #68727 (Remove a comment about pretty printer in formatting tests) - #68740 (Do not suggest things named underscore) Failed merges: r? @ghost
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Feb 1, 2020
This comment has been minimized.
This comment has been minimized.
|
Failed in #68747 (comment) |
862af62
to
8ee30db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
GuillaumeGomez commentedJan 30, 2020
Fixes #16017.
Reopening of #64724.
cc @tomjakubowski
cc @ollie27
r? @kinnison