Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On mismatched argument count point at arguments #68877

Merged
merged 1 commit into from Feb 20, 2020

Conversation

@estebank
Copy link
Contributor

estebank commented Feb 6, 2020

No description provided.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 6, 2020

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 7, 2020

☔️ The latest upstream changes (presumably #68907) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank estebank force-pushed the estebank:point-at-params branch from 8743aff to fd7316d Feb 9, 2020
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Feb 11, 2020

r=me after squashing the commits

@estebank estebank force-pushed the estebank:point-at-params branch from 69a089a to 683ebc2 Feb 11, 2020
@estebank

This comment has been minimized.

Copy link
Contributor Author

estebank commented Feb 11, 2020

@bors r=petrochenkov

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 11, 2020

📌 Commit 683ebc2 has been approved by petrochenkov

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 12, 2020
…enkov

On mismatched argument count point at arguments
bors added a commit that referenced this pull request Feb 12, 2020
Rollup of 10 pull requests

Successful merges:

 - #67695 (Added dyn and true keyword docs)
 - #68241 (Migrate borrowck dataflow impls to new framework)
 - #68679 (Improve `ty.needs_drop`)
 - #68848 (Hasten macro parsing)
 - #68877 (On mismatched argument count point at arguments)
 - #69027 (Add missing `_zeroed` varants to `AllocRef`)
 - #69032 (ICE in nightly-2020-02-08: handle TerminatorKind::Yield in librustc_mir::transform::promote_consts::Validator method)
 - #69058 (Preparation for allocator aware `Box`)
 - #69070 (Add self to .mailmap)
 - #69077 (Fix outdated doc comment.)

Failed merges:

r? @ghost
@JohnTitor

This comment has been minimized.

Copy link
Member

JohnTitor commented Feb 12, 2020

Seems failed in #69085 (comment)
@bors r-

@bors bors removed the S-waiting-on-bors label Feb 12, 2020
@estebank

This comment has been minimized.

Copy link
Contributor Author

estebank commented Feb 12, 2020

@estebank

This comment has been minimized.

Copy link
Contributor Author

estebank commented Feb 20, 2020

After #69265, @bors r=petrochenkov

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 20, 2020

📌 Commit 683ebc2 has been approved by petrochenkov

@bors bors added S-waiting-on-bors and removed S-blocked labels Feb 20, 2020
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 20, 2020

⌛️ Testing commit 683ebc2 with merge 1a501df...

bors added a commit that referenced this pull request Feb 20, 2020
On mismatched argument count point at arguments
@Centril

This comment has been minimized.

Copy link
Member

Centril commented Feb 20, 2020

@bors retry yielding to higher prio PR.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 20, 2020

⌛️ Testing commit 683ebc2 with merge 83e4e89...

bors added a commit that referenced this pull request Feb 20, 2020
On mismatched argument count point at arguments
@Centril

This comment has been minimized.

Copy link
Member

Centril commented Feb 20, 2020

@bors retry

bors added a commit that referenced this pull request Feb 20, 2020
Rollup of 5 pull requests

Successful merges:

 - #68877 (On mismatched argument count point at arguments)
 - #69185 (Unify and improve const-prop lints)
 - #69305 (Tweak binding lifetime suggestion text)
 - #69311 (Clean up E0321 and E0322)
 - #69317 (Fix broken link to the rustc guide)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 20, 2020

⌛️ Testing commit 683ebc2 with merge 2c462a2...

@bors bors merged commit b680a5e into rust-lang:master Feb 20, 2020
4 of 5 checks passed
4 of 5 checks passed
homu Testing commit 683ebc2dec0a5b88eb3eaf146e6855ea299d17b8 with merge 2c462a2f776b899d46743b1b44eda976e846e61d...
Details
pr Build #20200211.53 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.