Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra subslice lowering #69128

Merged
merged 1 commit into from Feb 15, 2020
Merged

Fix extra subslice lowering #69128

merged 1 commit into from Feb 15, 2020

Conversation

@Centril
Copy link
Member

Centril commented Feb 13, 2020

We are currently ICEing on e.g.

fn main() {
    let [.., b @ ..] = [1, 2];
    b;
}

This happens because b @ .. registers a binding such that b; is OK, but then we forget to lower that binding in rustc_ast_lowering.

Fixes #69103.

r? @davidtwco

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Feb 13, 2020

Discussed in the T-compiler triage meeting this morning and decided to approve for beta backport.

@davidtwco

This comment has been minimized.

Copy link
Member

davidtwco commented Feb 14, 2020

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 14, 2020

📌 Commit f5bd964 has been approved by davidtwco

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 14, 2020
Fix extra subslice lowering

We are currently ICEing on e.g.
```rust
fn main() {
    let [.., b @ ..] = [1, 2];
    b;
}
```
This happens because `b @ ..` registers a binding such that `b;` is OK, but then we forget to lower that binding in `rustc_ast_lowering`.

Fixes rust-lang#69103.

r? @davidtwco
bors added a commit that referenced this pull request Feb 14, 2020
Rollup of 7 pull requests

Successful merges:

 - #68129 (Correct inference of primitive operand type behind binary operation)
 - #68475 (Use a `ParamEnvAnd<Predicate>` for caching in `ObligationForest`)
 - #68856 (typeck: clarify def_bm adjustments & add tests for or-patterns)
 - #69051 (simplify_try: address some of eddyb's comments)
 - #69128 (Fix extra subslice lowering)
 - #69150 (Follow-up to #68848)
 - #69164 (Update pulldown-cmark dependency)

Failed merges:

r? @ghost
@bors bors merged commit f5bd964 into rust-lang:master Feb 15, 2020
4 checks passed
4 checks passed
pr Build #20200213.23 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@Centril Centril deleted the Centril:fix-69103 branch Feb 15, 2020
bors added a commit that referenced this pull request Feb 22, 2020
[beta] beta backports

This backports the following PRs:

* Revert "Remove `checked_add` in `Layout::repeat`" #69241
* Do not ICE when encountering `yield` inside `async` block #69175
* Fix MIR typeck soundness holes #69145
* Fix extra subslice lowering #69128
* Correct ICE caused by macros generating invalid spans. #68611
* Make conflicting_repr_hints a deny-by-default c-future-compat lint #68586
bors added a commit that referenced this pull request Feb 23, 2020
[beta] beta backports

This backports the following PRs:

* Revert "Remove `checked_add` in `Layout::repeat`" #69241
* Do not ICE when encountering `yield` inside `async` block #69175
* Fix MIR typeck soundness holes #69145
* Fix extra subslice lowering #69128
* Correct ICE caused by macros generating invalid spans. #68611
* Make conflicting_repr_hints a deny-by-default c-future-compat lint #68586
bors added a commit that referenced this pull request Feb 24, 2020
[beta] beta backports

This backports the following PRs:

* Revert "Remove `checked_add` in `Layout::repeat`" #69241
* Do not ICE when encountering `yield` inside `async` block #69175
* Fix MIR typeck soundness holes #69145
* Fix extra subslice lowering #69128
* Correct ICE caused by macros generating invalid spans. #68611
* Make conflicting_repr_hints a deny-by-default c-future-compat lint #68586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.