Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generator miscompilations #69302

Merged
merged 7 commits into from Feb 22, 2020
Merged

Conversation

@jonas-schievink
Copy link
Member

jonas-schievink commented Feb 19, 2020

Fixes #69039

r? @Zoxc

@@ -519,12 +519,12 @@ macro_rules! make_mir_visitor {
resume_arg,
drop: _,
} => {
self.visit_operand(value, source_location);

This comment has been minimized.

Copy link
@Zoxc

Zoxc Feb 19, 2020

Contributor

Where does this reordering matter?

This comment has been minimized.

Copy link
@jonas-schievink

jonas-schievink Feb 19, 2020

Author Member

It doesn't seem to matter from what I've seen, but it aligns the order of Yield with the one for Call. That seems less surprising to me.

@jonas-schievink jonas-schievink force-pushed the jonas-schievink:yield-needs-storage branch from fa9da76 to fc2702c Feb 19, 2020
@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Feb 21, 2020

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 21, 2020

📌 Commit fc2702c has been approved by Zoxc

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 22, 2020

⌛️ Testing commit fc2702c with merge d735ede...

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 22, 2020

☀️ Test successful - checks-azure
Approved by: Zoxc
Pushing d735ede to master...

@bors bors added the merged-by-bors label Feb 22, 2020
@bors bors merged commit d735ede into rust-lang:master Feb 22, 2020
5 checks passed
5 checks passed
homu Test successful
Details
pr Build #20200219.45 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@jonas-schievink jonas-schievink deleted the jonas-schievink:yield-needs-storage branch Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.