Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak binding lifetime suggestion text #69305

Merged
merged 1 commit into from Feb 20, 2020
Merged

Conversation

@estebank
Copy link
Contributor

estebank commented Feb 20, 2020

We already have a structured suggestion, but the wording made it seem like that wasn't the case.

Fix #65286. r? @varkor

We already have a structured suggestion, but the wording made it seem
like that wasn't the case.
Fix #65286. r? @varkor
@Dylan-DPC

This comment has been minimized.

Copy link
Member

Dylan-DPC commented Feb 20, 2020

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 20, 2020

📌 Commit c816430 has been approved by Dylan-DPC

bors added a commit that referenced this pull request Feb 20, 2020
Rollup of 5 pull requests

Successful merges:

 - #68877 (On mismatched argument count point at arguments)
 - #69185 (Unify and improve const-prop lints)
 - #69305 (Tweak binding lifetime suggestion text)
 - #69311 (Clean up E0321 and E0322)
 - #69317 (Fix broken link to the rustc guide)

Failed merges:

r? @ghost
@bors bors merged commit 1facbb8 into rust-lang:master Feb 20, 2020
4 checks passed
4 checks passed
pr Build #20200220.2 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@@ -4,7 +4,7 @@ error[E0310]: the parameter type `T` may not live long enough
LL | impl <T: Sync> Foo for T { }
| -- ^^^
| |
| help: consider adding an explicit lifetime bound `T: 'static`...
| help: consider adding an explicit lifetime bound...: `T: 'static +`

This comment has been minimized.

Copy link
@varkor

varkor Feb 20, 2020

Member

Ellipsis followed by a colon looks a little strange. Maybe

help: consider adding an explicit lifetime bound: `T: 'static + ...`

would work better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.