Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link in task::Wake docs #70730

Merged
merged 1 commit into from Apr 3, 2020
Merged

Conversation

yoshuawuyts
Copy link
Member

@yoshuawuyts yoshuawuyts commented Apr 3, 2020

task::Wake was introduced in #68700. While I was browsing the docs I noticed a link to sync::Arc wasn't resolving correctly. This patch fixes that. Thanks!

Before

Screenshot_2020-04-03 std task Wake - Rust

Proposed

Screenshot_2020-04-03 alloc task Wake - Rust

@rust-highfive
Copy link
Collaborator

@rust-highfive rust-highfive commented Apr 3, 2020

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review label Apr 3, 2020
@Dylan-DPC-zz
Copy link

@Dylan-DPC-zz Dylan-DPC-zz commented Apr 3, 2020

@bors r+ rollup

@bors
Copy link
Contributor

@bors bors commented Apr 3, 2020

📌 Commit 3d17993 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Apr 3, 2020
bors added a commit to rust-lang-ci/rust that referenced this issue Apr 3, 2020
Rollup of 6 pull requests

Successful merges:

 - rust-lang#70696 (Extend rust-lang#69020 test to include reversed operand order.)
 - rust-lang#70706 (Minor cleanup in rustdoc --check-theme)
 - rust-lang#70725 (Avoid `.unwrap()`s on `.span_to_snippet(...)`s)
 - rust-lang#70728 (Minor doc improvements on `AllocRef`)
 - rust-lang#70730 (Fix link in task::Wake docs)
 - rust-lang#70731 (Minor follow-up after renaming librustc(_middle))

Failed merges:

r? @ghost
@bors bors merged commit 15be59d into rust-lang:master Apr 3, 2020
7 checks passed
@yoshuawuyts yoshuawuyts deleted the fix-wake-docs-link branch Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants