Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Avoid `Layout::array()` in `raw_vec.rs`. #75093
Conversation
A non-generic equivalent results in less LLVM IR and faster compilation.
|
This gave me wins of up to 1.9% locally, but changes to this code can be unpredictable in terms of performance, so let's see what it looks like on CI. @bors try @rust-timer queue |
|
Awaiting bors try build completion |
Avoid `Layout::array()` in `raw_vec.rs`. A non-generic equivalent results in less LLVM IR and faster compilation. r? @Amanieu
|
|
|
Queued f7180d1 with parent 1b0ff9e, future comparison URL. |
|
Finished benchmarking try commit (f7180d1): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
|
Small max-rss improvement, minimal regression everywhere else. |
A non-generic equivalent results in less LLVM IR and faster compilation.
r? @Amanieu