Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid `Layout::array()` in `raw_vec.rs`. #75093

Closed
wants to merge 1 commit into from

Conversation

@nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Aug 3, 2020

A non-generic equivalent results in less LLVM IR and faster compilation.

r? @Amanieu

A non-generic equivalent results in less LLVM IR and faster compilation.
@nnethercote
Copy link
Contributor Author

@nnethercote nnethercote commented Aug 3, 2020

This gave me wins of up to 1.9% locally, but changes to this code can be unpredictable in terms of performance, so let's see what it looks like on CI.

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

@rust-timer rust-timer commented Aug 3, 2020

Awaiting bors try build completion

@bors
Copy link
Contributor

@bors bors commented Aug 3, 2020

Trying commit 894236f with merge f7180d1...

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 3, 2020
Avoid `Layout::array()` in `raw_vec.rs`.

A non-generic equivalent results in less LLVM IR and faster compilation.

r? @Amanieu
@bors
Copy link
Contributor

@bors bors commented Aug 3, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: f7180d1 (f7180d1a199036f6f96d6791cbe6f58b00a890a4)

@rust-timer
Copy link
Collaborator

@rust-timer rust-timer commented Aug 3, 2020

Queued f7180d1 with parent 1b0ff9e, future comparison URL.

@rust-timer
Copy link
Collaborator

@rust-timer rust-timer commented Aug 3, 2020

Finished benchmarking try commit (f7180d1): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@mati865
Copy link
Contributor

@mati865 mati865 commented Aug 3, 2020

Small max-rss improvement, minimal regression everywhere else.

@nnethercote nnethercote closed this Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.