New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More naming cleanup of syntax::ast types. #7903

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@michaelwoerister
Contributor

michaelwoerister commented Jul 19, 2013

Continuation of #7826.

AST spanned refactoring, AST type renamings:

crate => Crate
local => Local
blk => Block
crate_num => CrateNum
crate_cfg => CrateConfig
field => Field

Also, Crate, Field and Local are not wrapped in spanned anymore.

@thestinger

This comment has been minimized.

Contributor

thestinger commented Jul 21, 2013

@michaelwoerister: looks like this needs to be rebased already

michaelwoerister added some commits Jul 19, 2013

Ast spanned<T> refactoring, renaming: crate, local, blk, crate_num, c…
…rate_cfg.

`crate => Crate`
`local => Local`
`blk => Block`
`crate_num => CrateNum`
`crate_cfg => CrateConfig`

Also, Crate and Local are not wrapped in spanned<T> anymore.
@michaelwoerister

This comment has been minimized.

Contributor

michaelwoerister commented Jul 22, 2013

Rebased :)

@jdm

This comment has been minimized.

jdm commented on 5aee3e0 Jul 22, 2013

r+

@bors

This comment has been minimized.

Contributor

bors commented on 5aee3e0 Jul 22, 2013

saw approval from jdm
at michaelwoerister@5aee3e0

This comment has been minimized.

Contributor

bors replied Jul 22, 2013

merging michaelwoerister/rust/end_of_spanned = 5aee3e0 into auto

This comment has been minimized.

Contributor

bors replied Jul 22, 2013

michaelwoerister/rust/end_of_spanned = 5aee3e0 merged ok, testing candidate = 52b7fc1

This comment has been minimized.

Contributor

bors replied Jul 22, 2013

fast-forwarding master to auto = 52b7fc1

bors added a commit that referenced this pull request Jul 22, 2013

auto merge of #7903 : michaelwoerister/rust/end_of_spanned, r=jdm
Continuation of #7826.

AST spanned<T> refactoring, AST type renamings:

`crate => Crate`
`local => Local`
`blk => Block`
`crate_num => CrateNum`
`crate_cfg => CrateConfig`
`field => Field`

Also, Crate, Field and Local are not wrapped in spanned<T> anymore.
@@ -33,7 +33,7 @@ trait fake_ext_ctxt {
type fake_session = parse::parse_sess;
impl fake_ext_ctxt for fake_session {
fn cfg() -> ast::crate_cfg { ~[] }
fn cfg() -> ast::Crate_cfg { ~[] }

This comment has been minimized.

@pcwalton

pcwalton Jul 22, 2013

Contributor

Shouldn't this be CrateConfig as above?

This comment has been minimized.

@michaelwoerister

michaelwoerister Jul 22, 2013

Contributor

Yes, it should :/
I always run make check before a PR or after a rebase, but I guess this does not run the full-deps tests, does it?

Thanks for pointing this out!

This comment has been minimized.

@michaelwoerister

michaelwoerister Jul 22, 2013

Contributor

Oh, and I just saw some of the above tests are x-failed, so they slip through the compiler checks too.

@bors bors closed this Jul 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment