Change the type of crust fns to extern "C"
#8666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -483,6 +484,7 @@ impl Builder { | |||
| debug!("Store %s -> %s", | |||
| self.ccx.tn.val_to_str(val), | |||
| self.ccx.tn.val_to_str(ptr)); | |||
| assert!(is_not_null(self.llbuilder)); | |||
bors
added a commit
that referenced
this pull request
Aug 22, 2013
…=pcwalton
Change the type of crust fns like this one:
extern fn foo() { ... }
from `*u8` to `extern "C" fn()`.
r? @pcwalton (or whomever)
MicahChalmer
added a commit
to MicahChalmer/rust-fuse-mc-original
that referenced
this pull request
Aug 27, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2022
Don't lint `while_let_loop` when significant drop order would change fixes rust-lang#7226 fixes rust-lang#7913 fixes rust-lang#5717 For rust-lang#5717 it may not stay fully fixed. This is only completely fixed right now due to all the allowed drop impls have `#[may_dangle]` on their drop impls. This may get changed in the future based on how significant drops are determined, but the example listed with `RefCell` shouldn't break. changelog: Don't lint `while_let_loop` when the order of significant drops would change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the type of crust fns like this one:
from
*u8toextern "C" fn().r? @pcwalton (or whomever)