do not emit overlap errors for impls failing the orphan check

[lcnr]

this should finally allow us to merge #86986, see #86986 (comment) for more details.

r? @nikomatsakis cc @eddyb

[lcnr]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 7d5a76d79c1f608f2e40cef7bbdba2dc4b172d7c with merge 1c8704cd0aa20806f32471eb07a5af01fa99f8d0...

[bors]

☀️ Try build successful - checks-actions
Build commit: 1c8704cd0aa20806f32471eb07a5af01fa99f8d0 (1c8704cd0aa20806f32471eb07a5af01fa99f8d0)

[rust-timer]

Queued 1c8704cd0aa20806f32471eb07a5af01fa99f8d0 with parent e015ef5, future comparison URL.

[bors]

☀️ Try build successful - checks-actions
Build commit: 1c8704cd0aa20806f32471eb07a5af01fa99f8d0 (1c8704cd0aa20806f32471eb07a5af01fa99f8d0)

[lcnr]

ok, const-and-non-const-impl.rs now has three more "type annotations needed" errors. The reason they were hidden before is a use of err_count() which is pretty fundamentally broken wrt the query system.

before we had

x = new InferCtxt
...
specialization_graph_of() // this errors and increases the error count
...
x.is_tainted_by_errors() // returns `true`

but we now have

orphan_check_impl() // this errors and increases the error count
...
x = new InferCtxt
...
specialization_graph_of() // this doesn't error because of the error in `orphan_check_impl` above
...
x.is_tainted_by_errors() // now returns `false`

Don't think that that should block this PR and believe that we stop using err_count like this long term.

[rust-timer]

Finished benchmarking commit (1c8704cd0aa20806f32471eb07a5af01fa99f8d0): comparison url.

Summary: This change led to large relevant mixed results 🤷 in compiler performance.

• Small improvement in instruction counts (up to -0.6% on incr-unchanged builds of tuple-stress)
• Large regression in instruction counts (up to 2.4% on full builds of inflate)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

[lcnr]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 9eb21cf7293d97200ea07dddb9c57bd7c86f4234 with merge 244bc66664402a4b88605f32a857fa71310bcc1d...

[bors]

☀️ Try build successful - checks-actions
Build commit: 244bc66664402a4b88605f32a857fa71310bcc1d (244bc66664402a4b88605f32a857fa71310bcc1d)

[rust-timer]

Queued 244bc66664402a4b88605f32a857fa71310bcc1d with parent e015ef5, future comparison URL.

[rust-timer]

Finished benchmarking commit (244bc66664402a4b88605f32a857fa71310bcc1d): comparison url.

Summary: This change led to large relevant mixed results 🤷 in compiler performance.

• Small improvement in instruction counts (up to -0.7% on incr-unchanged builds of tuple-stress)
• Large regression in instruction counts (up to 2.4% on full builds of inflate)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

[lcnr]

@bors try @rust-timer queue

[lcnr]

alright, sure love a 2.4 % perf regression to be noise xx

should now be ready for merge i guess 😅

[bors]

☔ The latest upstream changes (presumably #86041) made this pull request unmergeable. Please resolve the merge conflicts.

[nikomatsakis]

@bors r+

[bors]

📌 Commit f55ff41 has been approved by nikomatsakis

[bors]

⌛ Testing commit f55ff41 with merge 1e3c735f4665ad4ebeb54e37b0cdfbff161fa69a...

[bors]

💥 Test timed out

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[lcnr]

@bors retry

[bors]

⌛ Testing commit f55ff41 with merge 1d34cb4...

[bors]

☀️ Test successful - checks-actions
Approved by: nikomatsakis
Pushing 1d34cb4 to master...

[rust-timer]

Finished benchmarking commit (1d34cb4): comparison url.

Summary: This change led to moderate relevant mixed results 🤷 in compiler performance.

• Small improvement in instruction counts (up to -0.5% on incr-unchanged builds of helloworld)
• Moderate regression in instruction counts (up to 0.5% on incr-patched: println builds of style-servo)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

[matthewjasper]

Perf "regressions" disappeared when the next PR was merged