Inline BuildHasherDefault<DefaultHasher>::build_hasher

[goffrie]

Today this doesn't get inlined causing <BuildHasherDefault<DefaultHasher> as BuildHasher>::hash_one to be more complex than it needs to be (as used in HashMap<K, V, BuildHasherDefault<DefaultHasher>>), but with inlining it should simplify a decent amount.

[rust-highfive]

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[rust-highfive]

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

[JohnTitor]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 72fd9b3 with merge 139793680cad215533aa0cc11a97be96bf22020e...

[rust-log-analyzer]

The job dist-x86_64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

     |
3147 |     #[inline]
     |     ^^^^^^^^^ help: remove this attribute
     |
     = note: `-D unused-attributes` implied by `-D warnings`
note: attribute also specified here
     |
3145 |     #[inline]
     |     ^^^^^^^^^
     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!

[bors]

💔 Test failed - checks-actions

[JohnTitor]

Seems part of fns has the attribute already on master, could you rebase?

[JohnCSimon]

ping from triage:
@goffrie
can you please rebase?

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.

[goffrie]

Looks like this isn't necessary any more