Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Span using interned pointers. #98352

Closed
wants to merge 2 commits into from
Closed

Implement Span using interned pointers. #98352

wants to merge 2 commits into from

Conversation

cjgillot
Copy link
Contributor

Perf only

r? @ghost

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 21, 2022
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 21, 2022
@bors
Copy link
Contributor

bors commented Jun 21, 2022

⌛ Trying commit a64683e with merge 9bff361f50324ff1c05a052e3c1445138c2c5a64...

bjorn3
bjorn3 reviewed Jun 21, 2022
View reviewed changes
compiler/rustc_span/src/span_encoding.rs
span_data
} else {
let span_data = Box::new(span_data);
let span_data = Box::leak(span_data);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a memory leak. Please store references to keep it alive in SpanInterner instead.

@bors
Copy link
Contributor

bors commented Jun 21, 2022

☀️ Try build successful - checks-actions
Build commit: 9bff361f50324ff1c05a052e3c1445138c2c5a64 (9bff361f50324ff1c05a052e3c1445138c2c5a64)

@rust-timer
Copy link
Collaborator

Queued 9bff361f50324ff1c05a052e3c1445138c2c5a64 with parent 72fd41a, future comparison URL.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9bff361f50324ff1c05a052e3c1445138c2c5a64): comparison url.

Instruction count

  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 3.6% 12.4% 205
Regressions 😿
(secondary)		 3.5% 12.4% 188
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -1.3% -1.6% 7
All 😿🎉 (primary) 3.6% 12.4% 205

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 5.4% 13.4% 195
Regressions 😿
(secondary)		 7.7% 38.8% 122
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -4.4% -4.4% 1
All 😿🎉 (primary) 5.4% 13.4% 195

Cycles

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 10.3% 33.6% 192
Regressions 😿
(secondary)		 12.1% 43.3% 139
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -1.7% -1.7% 1
All 😿🎉 (primary) 10.3% 33.6% 192

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 21, 2022
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 22, 2022
@bors
Copy link
Contributor

bors commented Jun 22, 2022

⌛ Trying commit d9d06b70ef21bab452c8fc7b9f53a718087e9b38 with merge 3533a2c0414956096ff0b680f6b87ebd1d1b5b45...

@bors
Copy link
Contributor

bors commented Jun 22, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2022
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Jun 22, 2022

⌛ Trying commit 412b9bb with merge 876335f4021704ed4de5e1b38307b9ea20406a99...

@bors
Copy link
Contributor

bors commented Jun 22, 2022

☀️ Try build successful - checks-actions
Build commit: 876335f4021704ed4de5e1b38307b9ea20406a99 (876335f4021704ed4de5e1b38307b9ea20406a99)

@rust-timer
Copy link
Collaborator

Queued 876335f4021704ed4de5e1b38307b9ea20406a99 with parent 10f4ce3, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (876335f4021704ed4de5e1b38307b9ea20406a99): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 0.5% 0.9% 4
Regressions 😿
(secondary)		 1.2% 3.5% 31
Improvements 🎉
(primary)		 -0.4% -1.2% 66
Improvements 🎉
(secondary)		 -0.8% -3.1% 45
All 😿🎉 (primary) -0.4% -1.2% 70

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 1.6% 6.3% 33
Regressions 😿
(secondary)		 2.2% 4.3% 18
Improvements 🎉
(primary)		 -1.7% -2.2% 3
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 1.3% 6.3% 36

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.2% 2.8% 4
Improvements 🎉
(primary)		 -2.6% -2.6% 1
Improvements 🎉
(secondary)		 -6.2% -10.3% 11
All 😿🎉 (primary) -2.6% -2.6% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Jun 23, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@cjgillot cjgillot closed this Jul 13, 2022
@cjgillot cjgillot deleted the span-ptr branch July 13, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cjgillot @rust-timer @bors @rust-log-analyzer @bjorn3 @rustbot