Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add humor appendix #350

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@mark-i-m
Copy link
Collaborator

commented Jun 26, 2019

Closes #163

r? @spastorino

@spastorino

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

I think the idea may be nice to be honest :). On the other hand there are some included things that I think doesn't belong to the compiler explicitly. I'm probably not the best person to check this kind of stuff though 😄

@mark-i-m

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 4, 2019

Oops sorry, I missed this. I do see your point... but the forge doesn't seem any better suited, and I can't think of anywhere else to host this.

@spastorino

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

@mark-i-m yeah, consider my position to this neutral 😄. If you want, go ahead and merge it, otherwise let's see what others say?.

@mark-i-m

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 11, 2019

Nobody else seems to have commented here after 2 weeks, so I will go ahead and merge it.

If a future traveler has opinions, feel free to leave them.

@mark-i-m mark-i-m merged commit 4936b7c into rust-lang:master Jul 11, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
@RalfJung

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Shouldn't that also mention break rust;? ;)

@mark-i-m

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 17, 2019

@RalfJung What is break rust;? I will gladly add it if you provide a link :)

@RalfJung

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

I am trying to find it again...

@RalfJung

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Found it.

@@ -93,4 +93,9 @@
[Appendix C: Glossary](./appendix/glossary.md)
[Appendix D: Code Index](./appendix/code-index.md)
[Appendix E: Bibliography](./appendix/bibliography.md)

[Appendix Z HumorRust](./appendix/humorust.md)

This comment has been minimized.

Copy link
@Phrohdoh

Phrohdoh Jul 18, 2019

Looks like there should have been a : after the Z.

This comment has been minimized.

Copy link
@mark-i-m

mark-i-m Jul 18, 2019

Author Collaborator

@Phrohdoh Yep, this was fixed recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.