-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collector refactoring, part 1 #1435
Conversation
|
This mostly seems fine. One suggestion: anything called |
|
I don't like utils.rs files that contain a lot of unrelated things, but I often create utils modules with a file per area of responsibility. A stylistic choice I guess :) Here I have done it mostly to orient myself in the code. The root contained several files that were intertwined a lot (some of them binaries, some of them included from main.rs, some of them included from lib.rs), so I wanted to group the files into directories to make sense of it. If you don't mind, I would keep it like this until I finish the refactoring, then if you find it clearer I can put the files back into the root. |
This should make it more obvious that they are indeed binaries.
…inished_first_collection`
0859eec
to
df6d078
Compare
|
Rebased on |
This is a series of commits that refactor the
collectorcrate in order to make it easier to use it as a library, remove unused code, better structure code to break up large files and to make future integration of runtime benchmarks easier. I will continue with other parts after (if) this gets merged.Best reviewed commit by commit.