Make perf. counter stats optional in BenchmarkStats
#1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnethercote
reviewed
Oct 18, 2022
nnethercote
reviewed
Oct 18, 2022
nnethercote
reviewed
Oct 18, 2022
nnethercote
approved these changes
Oct 18, 2022
This enables to run runtime benchmarks even in environments that do not support perf. event profiling fully (like CI).
Kobzol
force-pushed
the
runtime-optional-perf-counters
branch
from
5bf4260
to
142a732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables running runtime benchmarks even in environments that do not fully support perf. event counters (like CI). Basically it just avoids an unwrap and makes the perf. counter stats optional in runtime benchmark results.
It's still needed to have
perfworking and "openable" because we construct a counter group, but it's no longer needed to have all of the measured perf. counters available on the benchmarked machine.