Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for comma-separated include/exclude filters to runtime benchmarks #1471

Merged
merged 1 commit into from Oct 19, 2022

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Oct 18, 2022

Before the CLI help claimed commas are supported, but they weren't.

Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the compile-time and runtime benchmarks used the same code for this. E.g. the compile time benchmarks have some checking so that if you specify an entry that doesn't match anything you get an error, which is useful for catching typos.

@Kobzol
Copy link
Contributor Author

Kobzol commented Oct 19, 2022

I have it in my TODO list, it's a bit more complicated because the benchmark names are distributed amongst several binaries. Maybe I'll move the filtering to collector from benchlib.

@Kobzol Kobzol merged commit 4bb2c1e into master Oct 19, 2022
@Kobzol Kobzol deleted the runtime-cli-include-exclude branch October 19, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants