Store compare page UI filters into URL #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnethercote
approved these changes
Nov 2, 2022
Kobzol
force-pushed
the
compare-page-url
branch
from
e04113d
to
e88a8fe
Compare
rylev
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables users to quickly share links to the compare page with specific filters applied. Suggested by @nnethercote.
When clicking on quick links, only the filters that were active when the page was loaded will be forwarded. If you want to respect the current filter selection when using a quick link, reload the page first (F5). Otherwise the quick link would have to be generated dynamically, which seemed like unnecessary hassle.