Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store runtime benchmark results into SQLite #1515

Merged
merged 5 commits into from
Mar 5, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jan 23, 2023

Currently, each iteration of a runtime benchmark is stored with a fresh collection ID. This is something that we may want to change, although there is currently a unique index across (pstat_series, artifact_id and collection_id), so we cannot easily associate multiple metric sets with a single collection ID.

@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 21, 2023

ping @Mark-Simulacrum

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't review in too much detail but this looks fine to me at a high level. I imagine we can iterate on the specifics (e.g., whether we need a separate table for these benchmarks) over time - until we add Postgres support and start collecting in production we can throw the tables away easily without worrying about migrations etc.

@Kobzol Kobzol merged commit 3ed6e53 into rust-lang:master Mar 5, 2023
@Kobzol Kobzol deleted the runtime-db-sqlite branch March 5, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants