Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display doc benchmarks in dashboard #1533

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Display doc benchmarks in dashboard #1533

merged 1 commit into from
Mar 4, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Mar 2, 2023

It was missing from the dashboard.

@Kobzol Kobzol requested a review from rylev March 2, 2023 22:34
nnethercote
nnethercote approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we have historical data for doc builds?

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 3, 2023

I certainly hope so, I think that we gather all data when measuring released artifacts.

@Kobzol Kobzol merged commit 7088eb0 into master Mar 4, 2023
@Kobzol Kobzol deleted the doc-dashboard branch March 4, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnethercote nnethercote nnethercote approved these changes

@rylev rylev Awaiting requested review from rylev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kobzol @nnethercote