Add template rendering engine to site #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
approved these changes
Mar 9, 2023
|
Also, shouldn't we be removing the help.html static file? |
Yes, but the code currently checks that the HTML file exists, and it would need a larger refactoring to change that. And since I want to convert everything to templates anyway in a follow-up PR, I don't think that's worth it. |
Use Tera to render HTML templates. Only the help page has been ported to templates so far.
|
Pff, |
rylev
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Tera to render HTML templates. This will help us remove duplication (for the top link bar, general page layout, and shared Vue components).
Rendering a template takes about ~10 microseconds in release mode on my laptop. It's pretty much similar time to just reading the raw HTML file directly from disk (what was done before). Actually it could be a bit faster, as Tera now caches the template content in memory. But it shouldn't matter, as the HTML files are aggressively cached anyway using HTTP cache.
Only the help page has been ported to templates so far.
I didn't use e.g.
askama, because that inlines the templates into the binary, which would mean that livereloading would require a rebuild of thesitebinary (which takes seconds, so it's not exactly instant for interactive development).