Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare CI workflow for nightly releases #1555

Merged
merged 2 commits into from
May 19, 2023
Merged

Prepare CI workflow for nightly releases #1555

merged 2 commits into from
May 19, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Mar 15, 2023

This new CI workflow builds a rustc-perf site binary each day (night) and publishes it into a draft GH release. The release is overwritten each day, so we won't be spammed with hundreds of releases.

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 15, 2023

Here is the built release: https://github.com/rust-lang/rustc-perf/releases/tag/nightly.

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 31, 2023

Rebased over master. Once this is merged, we should be free to start using npm.

@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 5, 2023

I'd like to merge this before #1565 so that we can provide a nightly release for users that do not want to download npm to build the website.

Ping @Mark-Simulacrum

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems okay for now. Let's see how it works out in practice, we may want to put the site binary into our perf S3 bucket as an alternative to GHA if there's any problems with the overwriting here.

.github/workflows/nightly.yml Outdated Show resolved Hide resolved
@Kobzol
Copy link
Contributor Author

Kobzol commented May 19, 2023

I use a similar approach in a different repo and it works fine I think. The only issue is that the overwritten nightly release still keeps the "publication date" of the first release (so it looks like the release was published a long time ago), but that's just a cosmetic GitHub UI thing, the textual description of the release clearly states the date of the nightly.

@Kobzol Kobzol enabled auto-merge May 19, 2023 09:10
@Kobzol Kobzol merged commit fc55ec2 into master May 19, 2023
@Kobzol Kobzol deleted the ci-nightly branch May 19, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants