Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port compare page to Typescript #1581

Merged
merged 21 commits into from
May 19, 2023
Merged

Port compare page to Typescript #1581

merged 21 commits into from
May 19, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Apr 29, 2023

This was the largest UI page to port. It was partially in Vue before, so I mostly just copied it over, refactored it slightly and cleaned up various stuff.

@Kobzol Kobzol requested a review from rylev April 29, 2023 15:10
Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look at this super closely, but the overall shape looks good. I think this is an improvement over the status quo.

@Kobzol
Copy link
Contributor Author

Kobzol commented May 19, 2023

Ok, thanks! Let's ship it.

@Kobzol Kobzol merged commit fdbb4c1 into rust-lang:master May 19, 2023
@Kobzol Kobzol deleted the npm-compare branch May 19, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants