Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port detailed query page to TypeScript #1590

Merged
merged 3 commits into from
May 22, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 19, 2023

This should be the last page to port. The only remaining Javascript file is schedule.js, but I don't want to touch that.

@Kobzol Kobzol requested a review from lqd May 19, 2023 19:37
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Glad to see the migration complete 🚀 .

I've left a couple notes, mostly if we wanted to clean this page up in the future in another PR. Maybe some day.

site/frontend/src/pages/detailed-query.ts Outdated Show resolved Hide resolved
site/frontend/src/pages/detailed-query.ts Show resolved Hide resolved
site/frontend/src/pages/detailed-query.ts Outdated Show resolved Hide resolved
site/frontend/src/pages/detailed-query.ts Outdated Show resolved Hide resolved
site/frontend/src/utils/navigation.ts Outdated Show resolved Hide resolved
site/frontend/src/pages/detailed-query.ts Show resolved Hide resolved
@Kobzol
Copy link
Contributor Author

Kobzol commented May 22, 2023

I performed most of the suggested changes (I closed the comments otherwise this couldn't be merged).

@Kobzol Kobzol enabled auto-merge May 22, 2023 18:38
@Kobzol Kobzol merged commit 675346d into rust-lang:master May 22, 2023
@Kobzol Kobzol deleted the npm-detailed-query branch May 23, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants