Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compare page regression #1593

Merged
merged 2 commits into from
May 25, 2023
Merged

Fix compare page regression #1593

merged 2 commits into from
May 25, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 25, 2023

The URL wasn't being updated when filters have been changed. This is a regression from the TS port.

@Kobzol
Change URL when changing filters in compare page
efc9a8e 
This is a regression, I missed this functionality when porting the page to TypeScript.
@Kobzol
Refactor URL creation functions
6bf2587
@Kobzol Kobzol requested a review from lqd May 25, 2023 09:30
lqd
lqd approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine locally for me 👍

site/frontend/src/utils/copy.ts Show resolved Hide resolved
@Kobzol Kobzol merged commit 1a0c542 into rust-lang:master May 25, 2023
@Kobzol Kobzol deleted the compare-page-filters branch May 25, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqd lqd lqd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kobzol @lqd