Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store more runtime benchmark information into DB #1604

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Store more runtime benchmark information into DB #1604

merged 2 commits into from
Jun 5, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jun 3, 2023

All relevant metrics are now stored in to the DB, and the collector progress (the list shown on the status page) now also includes runtime benchmarks.

@Kobzol Kobzol requested a review from nnethercote June 3, 2023 10:00
nnethercote
nnethercote approved these changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm weak on both async Rust and databases, but I don't see any problems here :)

@Kobzol Kobzol merged commit 076b1f4 into rust-lang:master Jun 5, 2023
@Kobzol Kobzol deleted the runtime-db branch June 5, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnethercote nnethercote nnethercote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kobzol @nnethercote