Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed information about stable benchmarks into the site binary #1605

Merged
merged 1 commit into from
Jun 3, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jun 3, 2023

This fixes a long-standing FIXME, where the list of stable benchmarks was hard-coded, rather than being loaded from the filesystem. I checked that it doesn't regress compile times too much, in release it was basically the same, in debug it was ~1s slower. It adds about ~50 KiB to the release binary size after stripping.

@Kobzol Kobzol merged commit 2cabb6a into rust-lang:master Jun 3, 2023
@Kobzol Kobzol deleted the embed-stable-benchmarks branch June 3, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants