-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compare page UI #1612
Update compare page UI #1612
Conversation
|
Initial comments just based on the picture and video (I haven't really looked at the code).
Otherwise, seems reasonable. Having tabs is good. |
|
If you want to save vertical space, you could have smaller buttons to change tabs, a variety of heights, up to link-heights that could be positioned on the same line as the quick links. |
|
Using green for all improvements and red for all regressions looks fine to me. |
|
Changed tab to align it better with the existing summary, changed colors in summary table(s) and right-aligned the columns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only skimmed the code changes. The UI changes look good.

This PR modifies the UI of the compare page, with several goals:
The commits are mostly atomic and independent, so we can land only some of the changes, if they are too controversial.
More changes could be made, e.g. to put some things that belong together more closer together (such as the quick links with the "Do another comparison"), and in general the page could definitely use some UX love, but for now I think that this is good enough.
Before
After
Video (outdated design)
perf.mp4