Add basic runtime UI #1620
Merged
Add basic runtime UI #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the metric quick links will be triggered using JS and not as a normal HTML link, but as an advantage, we won't need to force refresh the component from the outside whenever the URL changes.
lqd
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
This is a step towards having the runtime UI available, it's not the final state. There are still some improvements to be made that Jakub and I have discussed.
The key point is that this PR shouldn't change the existing UI: it's a refactor, with a couple of tiny changes to the compile compare page (and people may have feedback on them) but that's it. So it's fine to land and we'll iterate in the future.
(I left a nit that you may ignore)
site/frontend/src/pages/compare/benchmarks/test-cases-table.vue
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes the compare page UI for both compile and runtime benchmarks, and adds basic runtime UI tab. It does not contain everything yet (links to benchmarks, filters), but should be usable as an MVP.
Best reviewed commit by commit 😅