Fix compilation of tendril-0.2.4
#1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stable benchmark did not compile since `1.69.0` because of UB caused by an unaligned reference to a packed struct member. This PR "vendors" the dependency and removes the `#[packed]` attribute to fix that.
Mark-Simulacrum
force-pushed
the
fix-html5ever
branch
from
ec986ba
to
726a091
Compare
Mark-Simulacrum
approved these changes
Jul 1, 2023
|
I don't see any explanation that this is a modified version of |
|
Good point! Did that here: #1633. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dependency of the stable benchmark
html5ever, which does not compile since1.69.0because of UB caused by an unaligned reference to a packed struct member. This PR "vendors" the dependency and removes the#[packed]attribute to fix that.We should also remove the errors for 1.69 and 1.70 from the DB and re-run this benchmark for these two versions.