Perform runtime benchmarks when benchmarking published artifacts #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no need for two structs, the `is_nightly` attribute is unused and it was basically the same as `LocalToolchain`.
It was causing issues with log printing.
Kobzol
force-pushed
the
runtime-bench-published
branch
from
cfac7af
to
b0f0fd8
Compare
nnethercote
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several cleanups that make it easier to run both compile and runtime benchmarks in the same
collectorexecution, and finally it enables runtime benchmarks when published artifacts are benchmarked.It can be tried e.g. with: