Generalize configuration of benchmarks #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will soon want to execute both compile and runtime benchmarks on multiple places. The current configuration of benchmarks was quite ad hoc. This PR introduces specialized config structs for both compile and runtime benchmarks (and also for configuration which is shared amongst them). It is a bit verbose, but also explicit. Eventually, most of the call sites in `collector` should transition to using the `run_benchmarks` function, but so far runtime benchmarks only run for `bench_runtime_local` and `bench_published`.
This also makes sure that the duration of the collection is recorded into the DB.
nnethercote
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will soon want to execute both compile and runtime benchmarks on multiple places. The current configuration of benchmarks was quite ad hoc. This PR introduces specialized config structs for both compile and runtime benchmarks (and also for configuration which is shared amongst them). It is a bit verbose, but also explicit.
All the call sites in
collectorare transitioned to using therun_benchmarksfunction, but so far runtime benchmarks only run forbench_runtime_localandbench_published.