Runtime benchmarks changes #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was unnecessarily long.
For consistency with other benchmarks
The mean is, despite my best efforts, often quite noisy, and we will probably display the min in the frontend anyway, so it should be the "default" value for gauging changes in benchmarks.
For consistency with other benchmarks
Kobzol
force-pushed
the
runtime-benchmarks-changes
branch
from
6e7e39e
to
455e4fa
Compare
This was referenced Jul 6, 2023
nnethercote
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performs some small changes to runtime benchmarks and the benchmark harness.
I will also send a series of PRs adding various new runtime benchmarks. I'm not claiming that we should use these for the "final" benchmark suite, I just want to add more diverse code here, so that we can find out issues on CI (too long/short benchmarks, slow compilation of runtime benchmarks, too much noise etc.).