Ignore duplicate values in artifact_collection_duration in Postgre
#1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1637, we record artifact duration collection unconditionally, even if some benchmarks were skipped (and thus computed sometime before). SQLite was able to handle this, but Postgre errors out on a duplicate key.
This PR changes the behaviour of Postgre to also ignore the duplicate records. This situation actually shouldn't even happen on the server (unless we manually backfill runtime benchmarks for an already benchmarked artifact, which we will probably want to do for a few artifacts), but it would be nice if it was handled gracefully anyway.