Add filters to runtime comparison tab #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
force-pushed
the
runtime-ui-ext
branch
2 times, most recently
from
5c4e1c2
to
730b725
Compare
|
Apart from the couple tiny things discussed with jakub, this LGTM. |
|
I resolved some of the comments, let me know what you think. |
lqd
approved these changes
Jul 27, 2023
The filters are actually synchronized, because they share some name of properties. When the filter changes, the URL is updated, and then when a tab is changed, it reloads the filter from the URL.
This makes the select box in compare/runtime page more precise, and it also fills it with relevant data if only runtime entries are present in the DB (this is only relevant for local execution of the site).
This basically reverts c7f618f, and applies the quick link refresh logic also for the runtime tab. I didn't realize before that using JS for the links makes it impossible to quickly open multiple metrics in a new tab, which is quite useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some basic filters to runtime benchmark table.