Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store runtime errors into the database #1651

Merged
merged 2 commits into from Jul 26, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jul 12, 2023

Stores both compilation and runtime errors of runtime benchmarks into the database. This should be the final step before we can actually execute runtime benchmarks on CI.

@Kobzol Kobzol force-pushed the runtime-error-handling branch 4 times, most recently from aed7529 to 6b0bf8d Compare July 17, 2023 06:57
@Kobzol Kobzol force-pushed the runtime-error-handling branch 2 times, most recently from 7436be1 to 3cbc8ad Compare July 18, 2023 09:31
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit but not strictly blocking.

collector/src/runtime/mod.rs Show resolved Hide resolved
@Kobzol Kobzol enabled auto-merge July 26, 2023 07:01
@Kobzol Kobzol merged commit 9468231 into rust-lang:master Jul 26, 2023
9 checks passed
@Kobzol Kobzol deleted the runtime-error-handling branch July 26, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants