Add perf. run duration estimation to PR comment #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have wished before for a link to the status page in the bot's comment to be able to see the queue, and since you're changing this code here, could you add that link as well please ? 🙏 |
Kobzol
force-pushed
the
queue-estimation-comment
branch
from
63db906
to
0721201
Compare
|
Done, the queue text is now a link to the status page. |
Kobzol
force-pushed
the
queue-estimation-comment
branch
from
0721201
to
964524f
Compare
The date recorded is the end of the collection, so we shouldn't add anything to it. It was implemented correctly for Postgres, but incorrectly for SQLite.
Kobzol
force-pushed
the
queue-estimation-comment
branch
from
964524f
to
11e5728
Compare
Mark-Simulacrum
approved these changes
Jul 17, 2023
Kobzol
force-pushed
the
queue-estimation-comment
branch
from
11e5728
to
3de3d06
Compare
|
I added a min. estimated time of 1 hour, if data is missing or if it's too fast for some reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little QoL improvement that adds a rough estimate of how long it should take until a perf. run result is available. This information is added to the "Queued , future comparison URL..." comment on PRs.
It's not precise, since the duration of individual runs can vary, sometimes a perf. run can fail soon, and sometimes a PR run "jump ahead" another one, so that it takes longer. But I think that it's nice to know at least a (probable) lower bound of the waiting time, not everyone knows of the status page, and even if you know about it, this will show you its current state more quickly.
The "queued" comment is automatically hidden when the benchmark run finishes, so the outdated/stale "There are currently N other artifacts..." text won't be visible for a long time.