From eee4f668c4b39fa1c73078f89586c737f04cb682 Mon Sep 17 00:00:00 2001 From: "Felix S. Klock II" Date: Tue, 9 Apr 2024 11:49:26 +0000 Subject: [PATCH 1/4] Initial triage report template. --- triage/2024-04-09.md | 207 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 207 insertions(+) create mode 100644 triage/2024-04-09.md diff --git a/triage/2024-04-09.md b/triage/2024-04-09.md new file mode 100644 index 000000000..8ce7c0d7c --- /dev/null +++ b/triage/2024-04-09.md @@ -0,0 +1,207 @@ +# 2024-04-09 Triage Log + +TODO: Summary + +Triage done by **@???**. +Revision range: [3d5528c287860b918e178a34f04ff903325571b3..86b603cd792b3f6172ba4f676d7b586c1af7630a](https://perf.rust-lang.org/?start=3d5528c287860b918e178a34f04ff903325571b3&end=86b603cd792b3f6172ba4f676d7b586c1af7630a&absolute=false&stat=instructions%3Au) + +**Summary**: + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions ❌
(primary) | 2.0% | [0.4%, 5.0%] | 83 | +| Regressions ❌
(secondary) | 2.1% | [0.5%, 4.8%] | 79 | +| Improvements ✅
(primary) | -1.5% | [-2.9%, -0.3%] | 121 | +| Improvements ✅
(secondary) | -1.4% | [-3.5%, -0.3%] | 67 | +| All ❌✅ (primary) | -0.1% | [-2.9%, 5.0%] | 204 | + + +3 Regressions, 3 Improvements, 7 Mixed; ??? of them in rollups +78 artifact comparisons made in total + +#### Regressions + +instantiate higher ranked goals outside of candidate selection [#119820](https://github.com/rust-lang/rust/pull/119820) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0accf4ec4c07d23aa86f6a97aeb8797941abc30e&end=43f4f2a3b1a3d3fb3dbbbe4fde33fb97c780ee98&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:----:|:------------:|:-----:| +| Regressions ❌
(primary) | 0.6% | [0.3%, 0.8%] | 8 | +| Regressions ❌
(secondary) | - | - | 0 | +| Improvements ✅
(primary) | - | - | 0 | +| Improvements ✅
(secondary) | - | - | 0 | +| All ❌✅ (primary) | 0.6% | [0.3%, 0.8%] | 8 | + + +Pass list of defineable opaque types into canonical queries [#122077](https://github.com/rust-lang/rust/pull/122077) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ab5bda1aa70f707014e2e691e43bc37a8819252a&end=b234e449443a49ab19ef6b712bf56cc65927d98f&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions ❌
(primary) | 1.9% | [0.2%, 5.4%] | 101 | +| Regressions ❌
(secondary) | 2.3% | [0.3%, 4.7%] | 77 | +| Improvements ✅
(primary) | -0.6% | [-0.6%, -0.6%] | 1 | +| Improvements ✅
(secondary) | - | - | 0 | +| All ❌✅ (primary) | 1.8% | [-0.6%, 5.4%] | 102 | + + +Replace some `CrateStore` trait methods with hooks. [#123099](https://github.com/rust-lang/rust/pull/123099) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=59c808fcd9eeb3c5528209d1cef3aaa5521edbd6&end=bd12986fd6659a3091cff7694b8225374f4a26fe&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:----:|:------------:|:-----:| +| Regressions ❌
(primary) | 0.3% | [0.2%, 0.4%] | 14 | +| Regressions ❌
(secondary) | 0.3% | [0.3%, 0.4%] | 2 | +| Improvements ✅
(primary) | - | - | 0 | +| Improvements ✅
(secondary) | - | - | 0 | +| All ❌✅ (primary) | 0.3% | [0.2%, 0.4%] | 14 | + + +#### Improvements + +hir: Drop owner's own item-local id (zero) from parenting tables [#123415](https://github.com/rust-lang/rust/pull/123415) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=703dc9ce64d9b31a239a7280d9b5f9ddd85ffed6&end=98efd808e1b77cd70a097620aad6250727167a28&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions ❌
(primary) | - | - | 0 | +| Regressions ❌
(secondary) | - | - | 0 | +| Improvements ✅
(primary) | -0.3% | [-0.4%, -0.2%] | 3 | +| Improvements ✅
(secondary) | -0.4% | [-1.3%, -0.3%] | 13 | +| All ❌✅ (primary) | -0.3% | [-0.4%, -0.2%] | 3 | + + +[perf] cache type info for ParamEnv [#123058](https://github.com/rust-lang/rust/pull/123058) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6f837503aa120ca69c2985b6c9a474c00674cef1&end=087ae978a13013800c8a484cf17c8951ab0b6b0c&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions ❌
(primary) | - | - | 0 | +| Regressions ❌
(secondary) | - | - | 0 | +| Improvements ✅
(primary) | -0.9% | [-4.9%, -0.2%] | 47 | +| Improvements ✅
(secondary) | - | - | 0 | +| All ❌✅ (primary) | -0.9% | [-4.9%, -0.2%] | 47 | + + +Remove debuginfo from rustc-demangle too [#123608](https://github.com/rust-lang/rust/pull/123608) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0e5f5207881066973486e6a480fa46cfa22947e9&end=75fd074338801fba74a8cf7f8c48c5c5be362d08&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions ❌
(primary) | - | - | 0 | +| Regressions ❌
(secondary) | 0.6% | [0.4%, 0.9%] | 4 | +| Improvements ✅
(primary) | -1.6% | [-2.7%, -0.3%] | 7 | +| Improvements ✅
(secondary) | -1.3% | [-2.4%, -0.3%] | 24 | +| All ❌✅ (primary) | -1.6% | [-2.7%, -0.3%] | 7 | + + +#### Mixed + +Add `Ord::cmp` for primitives as a `BinOp` in MIR [#118310](https://github.com/rust-lang/rust/pull/118310) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=029cb1b13b6388b95e64e8996ec8b41a9f3cf16e&end=a77322c16f188402fa22a5e87100acce42433cbc&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions ❌
(primary) | 0.4% | [0.2%, 0.7%] | 3 | +| Regressions ❌
(secondary) | 0.3% | [0.2%, 0.4%] | 2 | +| Improvements ✅
(primary) | -0.6% | [-0.6%, -0.6%] | 1 | +| Improvements ✅
(secondary) | -3.1% | [-3.1%, -3.1%] | 1 | +| All ❌✅ (primary) | 0.2% | [-0.6%, 0.7%] | 4 | + + +Encode dep graph edges directly from the previous graph when promoting [#122070](https://github.com/rust-lang/rust/pull/122070) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d009f60b55fe4527e7ddf122bc4520f351d7b9d4&end=4563f70c3b599411836e285591479f4a3d364708&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions ❌
(primary) | - | - | 0 | +| Regressions ❌
(secondary) | 0.4% | [0.4%, 0.4%] | 1 | +| Improvements ✅
(primary) | -1.6% | [-3.1%, -0.2%] | 113 | +| Improvements ✅
(secondary) | -1.5% | [-3.6%, -0.3%] | 37 | +| All ❌✅ (primary) | -1.6% | [-3.1%, -0.2%] | 113 | + + +Implement T-types suggested logic for perfect non-local impl detection [#122747](https://github.com/rust-lang/rust/pull/122747) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ea40fa210b87a322d2259852c149ffa212a3a0da&end=9d79cd5f79e75bd0d2083260271307ce9acd9081&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions ❌
(primary) | 2.3% | [0.6%, 4.4%] | 12 | +| Regressions ❌
(secondary) | - | - | 0 | +| Improvements ✅
(primary) | -0.3% | [-0.4%, -0.2%] | 9 | +| Improvements ✅
(secondary) | - | - | 0 | +| All ❌✅ (primary) | 1.2% | [-0.4%, 4.4%] | 21 | + + +Remove sharding for VecCache [#123556](https://github.com/rust-lang/rust/pull/123556) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=087ae978a13013800c8a484cf17c8951ab0b6b0c&end=af2525317be950fdae635bcbb46b3e755d14ab49&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions ❌
(primary) | 0.4% | [0.4%, 0.4%] | 1 | +| Regressions ❌
(secondary) | 0.5% | [0.2%, 1.0%] | 5 | +| Improvements ✅
(primary) | - | - | 0 | +| Improvements ✅
(secondary) | -0.9% | [-1.1%, -0.7%] | 4 | +| All ❌✅ (primary) | 0.4% | [0.4%, 0.4%] | 1 | + + +Use unchecked_sub in str indexing [#123561](https://github.com/rust-lang/rust/pull/123561) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fc1a4c5cc9308c4b5980c64a73fd344a59c10601&end=4e431fad67b46c480f1833119cd368fa33df95f7&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions ❌
(primary) | 0.9% | [0.9%, 0.9%] | 1 | +| Regressions ❌
(secondary) | - | - | 0 | +| Improvements ✅
(primary) | - | - | 0 | +| Improvements ✅
(secondary) | -0.5% | [-0.9%, -0.4%] | 7 | +| All ❌✅ (primary) | 0.9% | [0.9%, 0.9%] | 1 | + + +Rollup of 9 pull requests [#123645](https://github.com/rust-lang/rust/pull/123645) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=211518e5fb1336de6a4aab45dc1c05f5d83ce856&end=ab5bda1aa70f707014e2e691e43bc37a8819252a&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions ❌
(primary) | 0.6% | [0.6%, 0.6%] | 1 | +| Regressions ❌
(secondary) | - | - | 0 | +| Improvements ✅
(primary) | -0.3% | [-0.4%, -0.3%] | 2 | +| Improvements ✅
(secondary) | -1.8% | [-1.8%, -1.8%] | 1 | +| All ❌✅ (primary) | -0.0% | [-0.4%, 0.6%] | 3 | + + +Only collect mono items from reachable blocks [#123272](https://github.com/rust-lang/rust/pull/123272) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=86b603cd792b3f6172ba4f676d7b586c1af7630a&end=bb78dba64ca4158ef2f3488d0d41a82c75a504f2&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions ❌
(primary) | 0.4% | [0.2%, 1.5%] | 8 | +| Regressions ❌
(secondary) | - | - | 0 | +| Improvements ✅
(primary) | -0.8% | [-1.5%, -0.3%] | 6 | +| Improvements ✅
(secondary) | - | - | 0 | +| All ❌✅ (primary) | -0.1% | [-1.5%, 1.5%] | 14 | + + +#### Untriaged Pull Requests + +- [#123645 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/123645) +- [#123561 Use unchecked_sub in str indexing](https://github.com/rust-lang/rust/pull/123561) +- [#123272 Only collect mono items from reachable blocks](https://github.com/rust-lang/rust/pull/123272) +- [#123147 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/123147) +- [#122976 Remove len argument from RawVec::reserve_for_push](https://github.com/rust-lang/rust/pull/122976) +- [#122900 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/122900) +- [#122671 Codegen const panic messages as function calls](https://github.com/rust-lang/rust/pull/122671) +- [#122396 Less generic code for Vec allocations](https://github.com/rust-lang/rust/pull/122396) +- [#121955 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/121955) +- [#121804 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/121804) +- [#121752 Detect unused struct impls pub trait](https://github.com/rust-lang/rust/pull/121752) +- [#121462 Combine `Sub` and `Equate`](https://github.com/rust-lang/rust/pull/121462) +- [#121345 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/121345) +- [#120985 Update host LLVM on x64 Linux to LLVM 18](https://github.com/rust-lang/rust/pull/120985) +- [#120863 Use intrinsics::debug_assertions in debug_assert_nounwind](https://github.com/rust-lang/rust/pull/120863) +- [#120862 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/120862) +- [#120809 Use `transmute_unchecked` in `NonZero::new`.](https://github.com/rust-lang/rust/pull/120809) +- [#120588 wasm: Store rlib metadata in wasm object files](https://github.com/rust-lang/rust/pull/120588) +- [#120504 Vec::try_with_capacity](https://github.com/rust-lang/rust/pull/120504) +- [#120401 Rollup of 12 pull requests](https://github.com/rust-lang/rust/pull/120401) +- [#120335 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/120335) +- [#119662 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/119662) +- [#119204 macro_rules: Less hacky heuristic for using `tt` metavariable spans](https://github.com/rust-lang/rust/pull/119204) +- [#119002 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/119002) +- [#118661 Restore `const PartialEq`](https://github.com/rust-lang/rust/pull/118661) +- [#118473 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/118473) +- [#118420 Introduce support for `async gen` blocks](https://github.com/rust-lang/rust/pull/118420) +- [#118405 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/118405) +- [#118319 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/118319) +- [#118310 Add `Ord::cmp` for primitives as a `BinOp` in MIR](https://github.com/rust-lang/rust/pull/118310) + +#### Nags requiring follow up + +TODO: Nags + From b58a81ab5c59861a02f4085b4f2fe4e90d6808b2 Mon Sep 17 00:00:00 2001 From: "Felix S. Klock II" Date: Tue, 9 Apr 2024 11:49:26 +0000 Subject: [PATCH 2/4] Triage report template with shortened commit ids --- triage/2024-04-09.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/triage/2024-04-09.md b/triage/2024-04-09.md index 8ce7c0d7c..4dd252692 100644 --- a/triage/2024-04-09.md +++ b/triage/2024-04-09.md @@ -3,7 +3,7 @@ TODO: Summary Triage done by **@???**. -Revision range: [3d5528c287860b918e178a34f04ff903325571b3..86b603cd792b3f6172ba4f676d7b586c1af7630a](https://perf.rust-lang.org/?start=3d5528c287860b918e178a34f04ff903325571b3&end=86b603cd792b3f6172ba4f676d7b586c1af7630a&absolute=false&stat=instructions%3Au) +Revision range: [3d5528c2..86b603cd](https://perf.rust-lang.org/?start=3d5528c287860b918e178a34f04ff903325571b3&end=86b603cd792b3f6172ba4f676d7b586c1af7630a&absolute=false&stat=instructions%3Au) **Summary**: From a894de1a6fe2391f2d874ec24cc20e928009500c Mon Sep 17 00:00:00 2001 From: "Felix S. Klock II" Date: Tue, 9 Apr 2024 20:59:35 +0000 Subject: [PATCH 3/4] initial round of fill-in for triage. --- triage/2024-04-09.md | 57 +++++++++++++------------------------------- 1 file changed, 17 insertions(+), 40 deletions(-) diff --git a/triage/2024-04-09.md b/triage/2024-04-09.md index 4dd252692..b78670b03 100644 --- a/triage/2024-04-09.md +++ b/triage/2024-04-09.md @@ -2,7 +2,7 @@ TODO: Summary -Triage done by **@???**. +Triage done by **@pnkfelix**. Revision range: [3d5528c2..86b603cd](https://perf.rust-lang.org/?start=3d5528c287860b918e178a34f04ff903325571b3&end=86b603cd792b3f6172ba4f676d7b586c1af7630a&absolute=false&stat=instructions%3Au) **Summary**: @@ -16,7 +16,7 @@ Revision range: [3d5528c2..86b603cd](https://perf.rust-lang.org/?start=3d5528c28 | All ❌✅ (primary) | -0.1% | [-2.9%, 5.0%] | 204 | -3 Regressions, 3 Improvements, 7 Mixed; ??? of them in rollups +3 Regressions, 3 Improvements, 7 Mixed; 1 of them in rollups 78 artifact comparisons made in total #### Regressions @@ -31,6 +31,7 @@ instantiate higher ranked goals outside of candidate selection [#119820](https:/ | Improvements ✅
(secondary) | - | - | 0 | | All ❌✅ (primary) | 0.6% | [0.3%, 0.8%] | 8 | +* already triaged by Jakub as an expected small performance regresison Pass list of defineable opaque types into canonical queries [#122077](https://github.com/rust-lang/rust/pull/122077) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ab5bda1aa70f707014e2e691e43bc37a8819252a&end=b234e449443a49ab19ef6b712bf56cc65927d98f&stat=instructions:u) @@ -42,6 +43,7 @@ Pass list of defineable opaque types into canonical queries [#122077](https://gi | Improvements ✅
(secondary) | - | - | 0 | | All ❌✅ (primary) | 1.8% | [-0.6%, 5.4%] | 102 | +* already triaged by oli, as an expected performance regression that is [justified](https://github.com/rust-lang/rust/pull/122077#issuecomment-1995694305) as an important bugfix Replace some `CrateStore` trait methods with hooks. [#123099](https://github.com/rust-lang/rust/pull/123099) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=59c808fcd9eeb3c5528209d1cef3aaa5521edbd6&end=bd12986fd6659a3091cff7694b8225374f4a26fe&stat=instructions:u) @@ -53,6 +55,7 @@ Replace some `CrateStore` trait methods with hooks. [#123099](https://github.co | Improvements ✅
(secondary) | - | - | 0 | | All ❌✅ (primary) | 0.3% | [0.2%, 0.4%] | 14 | +* already triaged by oli, categorized as noise. #### Improvements @@ -101,6 +104,7 @@ Add `Ord::cmp` for primitives as a `BinOp` in MIR [#118310](https://github.com/r | Improvements ✅
(secondary) | -3.1% | [-3.1%, -3.1%] | 1 | | All ❌✅ (primary) | 0.2% | [-0.6%, 0.7%] | 4 | +* The impact here is somewhat limited, and the graph indicates that the 0.69% instruction-count regression for image-0.24.1 was subsequently recovered. Encode dep graph edges directly from the previous graph when promoting [#122070](https://github.com/rust-lang/rust/pull/122070) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d009f60b55fe4527e7ddf122bc4520f351d7b9d4&end=4563f70c3b599411836e285591479f4a3d364708&stat=instructions:u) @@ -112,6 +116,7 @@ Encode dep graph edges directly from the previous graph when promoting [#122070] | Improvements ✅
(secondary) | -1.5% | [-3.6%, -0.3%] | 37 | | All ❌✅ (primary) | -1.6% | [-3.1%, -0.2%] | 113 | +* already marked as triaged by Jakub Implement T-types suggested logic for perfect non-local impl detection [#122747](https://github.com/rust-lang/rust/pull/122747) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ea40fa210b87a322d2259852c149ffa212a3a0da&end=9d79cd5f79e75bd0d2083260271307ce9acd9081&stat=instructions:u) @@ -123,6 +128,8 @@ Implement T-types suggested logic for perfect non-local impl detection [#122747] | Improvements ✅
(secondary) | - | - | 0 | | All ❌✅ (primary) | 1.2% | [-0.4%, 4.4%] | 21 | +* already marked as triaged by Urgau, with the comment "The perf regressions in diesel are due to the lint being triggered and producing nearly 300 warnings (with 155 actually shown)" +* (This reminds me of rustc-perf#1819) Remove sharding for VecCache [#123556](https://github.com/rust-lang/rust/pull/123556) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=087ae978a13013800c8a484cf17c8951ab0b6b0c&end=af2525317be950fdae635bcbb46b3e755d14ab49&stat=instructions:u) @@ -134,6 +141,7 @@ Remove sharding for VecCache [#123556](https://github.com/rust-lang/rust/pull/12 | Improvements ✅
(secondary) | -0.9% | [-1.1%, -0.7%] | 4 | | All ❌✅ (primary) | 0.4% | [0.4%, 0.4%] | 1 | +* already marked as triaged by simulacrum, presumably because this is likely noise since it is "just" removing the sharded type whose feature was not in use. Use unchecked_sub in str indexing [#123561](https://github.com/rust-lang/rust/pull/123561) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fc1a4c5cc9308c4b5980c64a73fd344a59c10601&end=4e431fad67b46c480f1833119cd368fa33df95f7&stat=instructions:u) @@ -145,6 +153,9 @@ Use unchecked_sub in str indexing [#123561](https://github.com/rust-lang/rust/pu | Improvements ✅
(secondary) | -0.5% | [-0.9%, -0.4%] | 7 | | All ❌✅ (primary) | 0.9% | [0.9%, 0.9%] | 1 | +* this is an improvement to the code for `str::get_unchecked` when overflow checks are enabled; its calling a compiler-intrinsic directly now. +* it really doesn't make any sense that it caused any regression at all. (Perhaps this change is causing a change to inlining decisions, at least for cargo?) +* marking as triaged. Rollup of 9 pull requests [#123645](https://github.com/rust-lang/rust/pull/123645) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=211518e5fb1336de6a4aab45dc1c05f5d83ce856&end=ab5bda1aa70f707014e2e691e43bc37a8819252a&stat=instructions:u) @@ -156,6 +167,7 @@ Rollup of 9 pull requests [#123645](https://github.com/rust-lang/rust/pull/12364 | Improvements ✅
(secondary) | -1.8% | [-1.8%, -1.8%] | 1 | | All ❌✅ (primary) | -0.0% | [-0.4%, 0.6%] | 3 | +* Looks like a temporary spike. Marking as triaged. Only collect mono items from reachable blocks [#123272](https://github.com/rust-lang/rust/pull/123272) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=86b603cd792b3f6172ba4f676d7b586c1af7630a&end=bb78dba64ca4158ef2f3488d0d41a82c75a504f2&stat=instructions:u) @@ -167,41 +179,6 @@ Only collect mono items from reachable blocks [#123272](https://github.com/rust- | Improvements ✅
(secondary) | - | - | 0 | | All ❌✅ (primary) | -0.1% | [-1.5%, 1.5%] | 14 | - -#### Untriaged Pull Requests - -- [#123645 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/123645) -- [#123561 Use unchecked_sub in str indexing](https://github.com/rust-lang/rust/pull/123561) -- [#123272 Only collect mono items from reachable blocks](https://github.com/rust-lang/rust/pull/123272) -- [#123147 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/123147) -- [#122976 Remove len argument from RawVec::reserve_for_push](https://github.com/rust-lang/rust/pull/122976) -- [#122900 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/122900) -- [#122671 Codegen const panic messages as function calls](https://github.com/rust-lang/rust/pull/122671) -- [#122396 Less generic code for Vec allocations](https://github.com/rust-lang/rust/pull/122396) -- [#121955 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/121955) -- [#121804 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/121804) -- [#121752 Detect unused struct impls pub trait](https://github.com/rust-lang/rust/pull/121752) -- [#121462 Combine `Sub` and `Equate`](https://github.com/rust-lang/rust/pull/121462) -- [#121345 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/121345) -- [#120985 Update host LLVM on x64 Linux to LLVM 18](https://github.com/rust-lang/rust/pull/120985) -- [#120863 Use intrinsics::debug_assertions in debug_assert_nounwind](https://github.com/rust-lang/rust/pull/120863) -- [#120862 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/120862) -- [#120809 Use `transmute_unchecked` in `NonZero::new`.](https://github.com/rust-lang/rust/pull/120809) -- [#120588 wasm: Store rlib metadata in wasm object files](https://github.com/rust-lang/rust/pull/120588) -- [#120504 Vec::try_with_capacity](https://github.com/rust-lang/rust/pull/120504) -- [#120401 Rollup of 12 pull requests](https://github.com/rust-lang/rust/pull/120401) -- [#120335 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/120335) -- [#119662 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/119662) -- [#119204 macro_rules: Less hacky heuristic for using `tt` metavariable spans](https://github.com/rust-lang/rust/pull/119204) -- [#119002 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/119002) -- [#118661 Restore `const PartialEq`](https://github.com/rust-lang/rust/pull/118661) -- [#118473 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/118473) -- [#118420 Introduce support for `async gen` blocks](https://github.com/rust-lang/rust/pull/118420) -- [#118405 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/118405) -- [#118319 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/118319) -- [#118310 Add `Ord::cmp` for primitives as a `BinOp` in MIR](https://github.com/rust-lang/rust/pull/118310) - -#### Nags requiring follow up - -TODO: Nags - +* fixed an important bug. +* from the comment history, it looks like the minor restricted regressions were anticipated. +* marking as triaged. From 61ca7ade62d2e8616b8e51cd7205fedf47d58ab8 Mon Sep 17 00:00:00 2001 From: "Felix S. Klock II" Date: Tue, 9 Apr 2024 21:03:25 +0000 Subject: [PATCH 4/4] wrote summary. --- triage/2024-04-09.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/triage/2024-04-09.md b/triage/2024-04-09.md index b78670b03..ece39c95e 100644 --- a/triage/2024-04-09.md +++ b/triage/2024-04-09.md @@ -1,6 +1,6 @@ # 2024-04-09 Triage Log -TODO: Summary +A quiet week; all the outright regressions were already triaged (the one biggish one was #122077, which is justified as an important bug fix). There was a very nice set of improvements from PR #122070, which cleverly avoids a lot of unnecessary allocator calls when building an incremental dep graph by reusing the old edges from the previous graph. Triage done by **@pnkfelix**. Revision range: [3d5528c2..86b603cd](https://perf.rust-lang.org/?start=3d5528c287860b918e178a34f04ff903325571b3&end=86b603cd792b3f6172ba4f676d7b586c1af7630a&absolute=false&stat=instructions%3Au) @@ -39,7 +39,7 @@ Pass list of defineable opaque types into canonical queries [#122077](https://gi |:----------------------------------:|:-----:|:--------------:|:-----:| | Regressions ❌
(primary) | 1.9% | [0.2%, 5.4%] | 101 | | Regressions ❌
(secondary) | 2.3% | [0.3%, 4.7%] | 77 | -| Improvements ✅
(primary) | -0.6% | [-0.6%, -0.6%] | 1 | + | Improvements ✅
(secondary) | - | - | 0 | | All ❌✅ (primary) | 1.8% | [-0.6%, 5.4%] | 102 |