Treat in-progress requests as completed when computing queue order #2315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
force-pushed
the
improve-queue-ordering
branch
from
5769f3b to
8b065a5
Compare
If all pending requests have a parent that is also pending or in-progress, then the queue ordering would get stuck on the "No master/try commit is ready for benchmarking" edge-case. We thus treat in-progress requests as already completed when computing the queue ordering.
Kobzol
force-pushed
the
improve-queue-ordering
branch
from
8b065a5 to
0b68a28
Compare
Jamesbarford
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all pending requests have a parent that is also pending or in-progress, then the queue ordering would get stuck on the "No master/try commit is ready for benchmarking" edge-case. We thus treat in-progress requests as already completed when computing the queue ordering.