Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix Cargo selection #644
Merged
Fix Cargo selection #644
Conversation
`base_command` currently tries to choose the Cargo version via `$CARGO`. But `cargo` doesn't consult `$CARGO`, so this has no effect, and the `cargo` used is whatever is found in `$PATH`. This commit fixes `base_command` to use the `cargo` specified in `Compiler::cargo`.
It doesn't seem useful any more.
|
This looks good to me. One thing that would be nice probably (though in a separate PR) is to gather the rustc -vV and cargo -vV output and dump it into the json we collect for (at least to start) manual inspection. |
Mark-Simulacrum
merged commit f636e7c
into
rust-lang:master
1 check passed
1 check passed
|
I will deploy tomorrow morning (presuming I don't forget...). |
|
Deployed this morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
On CI, this means that the correct Cargo revision (the one matching the rustc revision) is used, rather than whatever version of Cargo is found in
$PATH.For local runs, it means that the
--cargooption will be heeded, instead of it (again) just using whatever version of Cargo is found in$PATH.