Skip to content

Add --gcc-path option#608

Merged
antoyo merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:gcc-path
Jan 24, 2025
Merged

Add --gcc-path option#608
antoyo merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:gcc-path

Conversation

@GuillaumeGomez

@GuillaumeGomez GuillaumeGomez commented Jan 24, 2025

Copy link
Copy Markdown
Member

No description provided.

antoyo
antoyo reviewed Jan 24, 2025
View reviewed changes
Comment thread build_system/src/config.rs Outdated
Comment thread build_system/src/build.rs Outdated
@GuillaumeGomez

GuillaumeGomez commented Jan 24, 2025

Copy link
Copy Markdown
Member Author

Added comment and replaced unwrap calls with expect.

antoyo
antoyo reviewed Jan 24, 2025
View reviewed changes
Comment thread build_system/src/config.rs Outdated
Comment thread build_system/src/config.rs Outdated
@GuillaumeGomez

GuillaumeGomez commented Jan 24, 2025

Copy link
Copy Markdown
Member Author

Fixed the unwrap I forgot and I added messages to know the GCC path used by the build script.

@GuillaumeGomez

GuillaumeGomez commented Jan 24, 2025

Copy link
Copy Markdown
Member Author

Updated all expect messages.

@antoyo antoyo merged commit 5491581 into rust-lang:master Jan 24, 2025
@antoyo

antoyo commented Jan 24, 2025

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

@GuillaumeGomez GuillaumeGomez deleted the gcc-path branch January 24, 2025 20:34
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antoyo antoyo antoyo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuillaumeGomez @antoyo