fix clobbered or lateout registers overlapping with input registers#628
Conversation
d578ce9 to
8b2835c
Compare
antoyo
left a comment
There was a problem hiding this comment.
Looks good to me.
There are possibly two things to change.
8b2835c to
7f85f6b
Compare
|
locally I can't quite get that to work, but maybe something else needs to be updated? I did remove the line to see whether CI maybe did update correctly already. edit: it likely just needs the |
|
Oh, I forgot to update this file with the latest commit. |
|
I think so yes |
|
Could you please update the file with the latest commit from the gcc repo and see if this works? |
7f85f6b to
3ecc012
Compare
yes that does work, I've added it now. |
|
Is there any other change you would like to make or is this ready to merge? |
|
no I think we're good |
|
Thanks for your contribution! |
Apparently, in GCC, input registers cannot also be clobbered.
this previously errored https://godbolt.org/
this fixes half of
tests/ui/asm/x86_64/multiple-clobber-abi.rs, but it also runs into #451