Change the implementation of supports_parallel to signal tha cg_gcc is not thread safe. - #732
Merged
Merged
Conversation
bjorn3
reviewed
Jul 8, 2025
FractalFir
force-pushed
the
thread_soundness_fix
branch
from
July 8, 2025 20:56
25ae4e6 to
63c53fc
Compare
Contributor
Author
|
Ready for review. |
antoyo
reviewed
Jul 8, 2025
antoyo
left a comment
antoyo
left a comment
Contributor
There was a problem hiding this comment.
Good find!
Thanks for making this PR.
FractalFir
force-pushed
the
thread_soundness_fix
branch
2 times, most recently
from
July 9, 2025 18:28
8e6e2dc to
94fa5fe
Compare
…s not thread safe.
FractalFir
force-pushed
the
thread_soundness_fix
branch
from
July 9, 2025 18:29
94fa5fe to
2961464
Compare
Contributor
Author
|
Ready for review |
antoyo
approved these changes
Jul 9, 2025
Contributor
|
Thanks a lot for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This explicitly disables multithreading in
cg_gcc.libgccjitis not thread-safe, and this option should not have been accidentally enabled in the first place.