New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version-gate the trailing semicolon change of return statements inside a match arm #3250

Merged
merged 2 commits into from Dec 18, 2018

Conversation

Projects
None yet
2 participants
@scampi
Copy link
Collaborator

scampi commented Dec 14, 2018

Close #3229

scampi added some commits Dec 14, 2018

@scampi

This comment has been minimized.

Copy link
Collaborator

scampi commented Dec 14, 2018

The error comes from futures-rs which doesn't compile:

error[E0432]: unresolved import `std::marker::Pinned`
 --> futures-test/src/future/assert_unmoved.rs:4:5
  |
4 | use std::marker::Pinned;
  |     ^^^^^^^^^^^^^^^^^^^ no `Pinned` in `marker`
@topecongiro

This comment has been minimized.

Copy link
Collaborator

topecongiro commented Dec 18, 2018

LGTM, thanks!

@topecongiro topecongiro merged commit d1c7afe into rust-lang:master Dec 18, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@scampi scampi deleted the scampi:issue3229 branch Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment