New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trim_right/trim_left deprecation warnings #3252

Merged
merged 2 commits into from Dec 18, 2018

Conversation

Projects
None yet
2 participants
@phansch
Copy link
Contributor

phansch commented Dec 16, 2018

I saw these in the rustc tool build logs. Should I add a #![deny(deprecated)] as well?

phansch added some commits Dec 16, 2018

fmt

@phansch phansch force-pushed the phansch:fix_deprecations branch from 12b1591 to b8e8895 Dec 16, 2018

@topecongiro

This comment has been minimized.

Copy link
Collaborator

topecongiro commented Dec 18, 2018

Thank you for the fix!

Should I add a #![deny(deprecated)] as well?

It seems unnecessary. I am afraid that if we enable it, we may suddenly fail to build rustfmt and ship it via rustup due to just the lint error.

@topecongiro topecongiro merged commit d078595 into rust-lang:master Dec 18, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@phansch phansch deleted the phansch:fix_deprecations branch Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment