Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trim_right/trim_left deprecation warnings #3252

merged 2 commits into from Dec 18, 2018


Copy link

@phansch phansch commented Dec 16, 2018

I saw these in the rustc tool build logs. Should I add a #![deny(deprecated)] as well?

Copy link

Thank you for the fix!

Should I add a #![deny(deprecated)] as well?

It seems unnecessary. I am afraid that if we enable it, we may suddenly fail to build rustfmt and ship it via rustup due to just the lint error.

@topecongiro topecongiro merged commit d078595 into rust-lang:master Dec 18, 2018
@phansch phansch deleted the fix_deprecations branch December 18, 2018 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants