Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not to avoid self #3570

Merged
merged 2 commits into from May 21, 2019
Merged

not to avoid self #3570

merged 2 commits into from May 21, 2019

Conversation

rchaser53
Copy link
Contributor

fix: #3568

Copy link
Contributor

@topecongiro topecongiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I left an inline comment about minor refactoring, but otherwise, the code looks good to me.

src/imports.rs Outdated Show resolved Hide resolved
@rchaser53
Copy link
Contributor Author

Thank you the review. I fixed it.

@topecongiro topecongiro merged commit 0ef2144 into rust-lang:master May 21, 2019
@topecongiro
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use normalization can break self imports
2 participants