Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach rustup/rustbuild about optional components #1006

Open
brson opened this Issue Mar 23, 2017 · 5 comments

Comments

3 participants
@brson
Copy link
Contributor

brson commented Mar 23, 2017

Today rustup knows about two types of packages: components (required), and extensions (optional, non-default). Some components though want to be installed by default, but optional (like docs).

To do this we have to change the manifest format in a backwards-compatible way. I suggest that we add a key "optional = true" to components that don't need to be installed. The build-manifest tool invoked by rustbuild needs to be modified to emit this key, and rustup needs to be taught to consume it.

@brson brson referenced this issue Mar 23, 2017

Open

Making docs optional again #998

0 of 3 tasks complete
@Diggsey

This comment has been minimized.

Copy link
Contributor

Diggsey commented Mar 23, 2017

I have a slight preference for doing the opposite (ie. flagging extensions as being "install-by-default") so that components are always required, and extensions are always optional. What do you think?

@Diggsey Diggsey added this to Components & extensions in Issue Categorisation May 3, 2017

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented May 11, 2017

@Diggsey per discussion we decided to go with the original design, for backwards-compatibility concerns.

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented May 12, 2017

Once this feature exists, rustup-init also needs to be modified with a non-interactive commandline option to disable default components. If the interactive installer allows component selection (I don't recall) then that needs to be modified too, though it could be done as a followup.

@mikhail-m1

This comment has been minimized.

Copy link
Contributor

mikhail-m1 commented May 16, 2017

@mikhail-m1

This comment has been minimized.

Copy link
Contributor

mikhail-m1 commented May 18, 2017

add optional to build-manifest tool mikhail-m1/rust@35a30af. Shell I do pull request to rust-lang/rust?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.