Skip to content

/rustup.rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress bar for "installing component" step #1557

Closed
johnthagen opened this Issue Dec 1, 2018 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@johnthagen
@johnthagen
Copy link
Contributor

johnthagen commented Dec 1, 2018 •
edited

Some components, such as rust-docs and rust-src take a bit longer to install, even on SSD-equipped machines. These take even longer on Windows (#1540).

One thing that would help in these situations would be if the user could see the progress of the component install to:

  1. Get a sense for how long the component will take to finish installing
  2. Know that rustup isn't just hung up

Perhaps Cargo's new progress bar released in stable 1.30 could be reused in some way?

...
info: installing component 'rust-docs'
Installing [============>                                           ] 330/1400

@johnthagen johnthagen referenced this issue Dec 15, 2018

Open

rustup show fails with panic on Windows #1458

@johnthagen

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

johnthagen commented Dec 15, 2018

At least one user reported thinking that rustup was stuck when it got to installing rust-docs: #1458 (comment)

kinnison added a commit to kinnison/rustup.rs that referenced this issue Dec 27, 2018

@kinnison
rustup-dist: Use Download notifications to track install 
People have requested some indication of progress for long-running
install steps.  This commit re-uses the download tracker logic to
provide a progress bar (the length is the compressed component
tarball but should be good enough) to provide such feedback.

Fixes: rust-lang#1458, rust-lang#1557
ef14a81

@kinnison kinnison referenced this issue Dec 27, 2018

Merged

rustup-dist: Use Download notifications to track install #1593

kinnison added a commit to kinnison/rustup.rs that referenced this issue Dec 27, 2018

@kinnison
rustup-dist: Use Download notifications to track install 
People have requested some indication of progress for long-running
install steps.  This commit re-uses the download tracker logic to
provide a progress bar (the length is the compressed component
tarball but should be good enough) to provide such feedback.

Fixes: rust-lang#1557
77cbe9f

kinnison added a commit to kinnison/rustup.rs that referenced this issue Jan 8, 2019

@kinnison
rustup-dist: Use Download notifications to track install 
People have requested some indication of progress for long-running
install steps.  This commit re-uses the download tracker logic to
provide a progress bar (the length is the compressed component
tarball but should be good enough) to provide such feedback.

Fixes: rust-lang#1557
33d6a8c

kinnison added a commit to kinnison/rustup.rs that referenced this issue Jan 13, 2019

@kinnison
rustup-dist: Use Download notifications to track install 
People have requested some indication of progress for long-running
install steps.  This commit re-uses the download tracker logic to
provide a progress bar (the length is the compressed component
tarball but should be good enough) to provide such feedback.

Fixes: rust-lang#1557
771c120

kinnison added a commit to kinnison/rustup.rs that referenced this issue Jan 14, 2019

@kinnison
rustup-dist: Use Download notifications to track install 
People have requested some indication of progress for long-running
install steps.  This commit uses the new FileReaderWithProgress to
provide a progress bar (the length is the compressed component
tarball but should be good enough) to provide such feedback.

Fixes: rust-lang#1557

Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
66336e5

kinnison added a commit to kinnison/rustup.rs that referenced this issue Jan 14, 2019

@kinnison
rustup-dist: Use Download notifications to track install 
People have requested some indication of progress for long-running
install steps.  This commit uses the new FileReaderWithProgress to
provide a progress bar (the length is the compressed component
tarball but should be good enough) to provide such feedback.

Fixes: rust-lang#1557

Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
c8d7c8e

kinnison added a commit to kinnison/rustup.rs that referenced this issue Jan 14, 2019

@kinnison
rustup-dist: Use Download notifications to track install 
People have requested some indication of progress for long-running
install steps.  This commit uses the new FileReaderWithProgress to
provide a progress bar (the length is the compressed component
tarball but should be good enough) to provide such feedback.

Fixes: rust-lang#1557

Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
aaead82

@nrc nrc closed this in #1593 Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.