Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt-out from PATH modification #170

Closed
nodakai opened this Issue Mar 27, 2016 · 8 comments

Comments

Projects
None yet
6 participants
@nodakai
Copy link
Contributor

nodakai commented Mar 27, 2016

I don't like apps modifying my .*shrc

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Mar 28, 2016

Should be a way to do this both on the command line (and in turn from rustup-setup.sh) as well as interactively.

@futile

This comment has been minimized.

Copy link

futile commented Mar 28, 2016

Yes please, I'd prefer if it just told me the directory I need to add to my PATH.

@comex

This comment has been minimized.

Copy link

comex commented Mar 29, 2016

This should be opt-in, not out.

@Nemo157

This comment has been minimized.

Copy link
Contributor

Nemo157 commented Apr 9, 2016

At the very least this needs to be handled gracefully, my ~/.zshrc is marked read-only and trying to install rust-up gives:

→ curl https://sh.rustup.rs -sSf | sh
[...]
error: could not write rcfile file: '/Users/Nemo157/.zshrc' (Permission denied (os error 13))
rustup: command failed: /var/folders/p8/qd22z3cn44dfxcsrm1t4wrfh0000gn/T/tmp.CUqvam57/rustup-setup

EDIT: Luckily just temporarily removing it was enough to persuade rustup to install 😸.

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Apr 10, 2016

@Nemo157 Thanks for the report. I've opened a separate issue.

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Apr 21, 2016

This can be done both on the command line and interactively now.

@brson brson closed this Apr 21, 2016

@jimmycuadra

This comment has been minimized.

Copy link
Contributor

jimmycuadra commented Apr 21, 2016

@brson I don't like that it still modifies your rc file by default. That should be strictly opt-in, IMO. If that's really not possible for some reason, at least change the pre-install message to make it clear that you can opt-out via the advanced options. Right now you'd have to just try it to discover that it's possible to opt-out. Maybe something like, "If you do not want /whatever/.profile modified automatically, choose the advanced installation option."

@jimmycuadra

This comment has been minimized.

Copy link
Contributor

jimmycuadra commented Apr 21, 2016

Perhaps it would be even better to just make it a separate interactive step. "Would you like rustup to automatically update /whatever/.profile to add ~/.cargo to your PATH environment variable? yes/no"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.