Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upOpt-out from PATH modification #170
Comments
This comment has been minimized.
This comment has been minimized.
|
Should be a way to do this both on the command line (and in turn from rustup-setup.sh) as well as interactively. |
This comment has been minimized.
This comment has been minimized.
futile
commented
Mar 28, 2016
|
Yes please, I'd prefer if it just told me the directory I need to add to my PATH. |
This comment has been minimized.
This comment has been minimized.
comex
commented
Mar 29, 2016
|
This should be opt-in, not out. |
brson
referenced this issue
Mar 31, 2016
Closed
Allow the user to tell rustup-setup which toolchain to install initially #218
jrobeson
referenced this issue
Apr 1, 2016
Closed
Maybe `~/.profile` is where PATH modifications should go #211
brson
added
the
initial release
label
Apr 6, 2016
This comment has been minimized.
This comment has been minimized.
|
At the very least this needs to be handled gracefully, my
EDIT: Luckily just temporarily removing it was enough to persuade rustup to install |
This comment has been minimized.
This comment has been minimized.
|
@Nemo157 Thanks for the report. I've opened a separate issue. |
peschkaj
referenced this issue
Apr 13, 2016
Closed
I cannot run rustup and other executables right after installation on Mac OSX. #305
This comment has been minimized.
This comment has been minimized.
|
This can be done both on the command line and interactively now. |
brson
closed this
Apr 21, 2016
This comment has been minimized.
This comment has been minimized.
|
@brson I don't like that it still modifies your rc file by default. That should be strictly opt-in, IMO. If that's really not possible for some reason, at least change the pre-install message to make it clear that you can opt-out via the advanced options. Right now you'd have to just try it to discover that it's possible to opt-out. Maybe something like, "If you do not want /whatever/.profile modified automatically, choose the advanced installation option." |
This comment has been minimized.
This comment has been minimized.
|
Perhaps it would be even better to just make it a separate interactive step. "Would you like rustup to automatically update /whatever/.profile to add ~/.cargo to your PATH environment variable? yes/no" |
nodakai commentedMar 27, 2016
I don't like apps modifying my
.*shrc